feat: add client-foldkit to catalog#130
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a3cc22b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lloydrichards
force-pushed
the
refactor/client-react-rename
branch
from
10e9354 to
00ce8f4
Compare
lloydrichards
force-pushed
the
feat/client-foldkit-scaffold
branch
2 times, most recently
from
5131d04 to
e1e49dd
Compare
lloydrichards
force-pushed
the
feat/client-foldkit-scaffold
branch
from
e1e49dd to
a3cc22b
Compare
Merged
Owner
Author
flowchart LR
classDef new fill:#10b981,color:#000
0["init"]
1["client-react"]
2["client-foldkit"]:::new
3["server"]
4["cli"]
5["package"]
6["turbo"]
7["biome"]
8["dprint"]
9["oxlint"]
10["vitest"]
11["git-init"]
12["config-typescript-vite"]
13["domain-api"]
14["domain-rpc"]
15["domain-chat"]
16["domain-websocket"]
17["http-api-server"]
18["http-rpc-server"]
19["chat-server"]
20["ws-presence-server"]
21["http-api-react-client"]
22["http-rpc-react-client"]
23["chat-react-client"]
24["ws-presence-react-client"]
25["http-api-foldkit-client"]:::new
26["http-rpc-foldkit-client"]:::new
27["ws-presence-foldkit-client"]:::new
28["chat-foldkit-client"]:::new
29["ai"]
30["ai-sample-toolkit"]
31["ai-chat-service"]
32["presence"]
33["hello-command"]
6 -->|"supportedOn"| 0
7 -->|"supportedOn"| 0
8 -->|"supportedOn"| 0
9 -->|"supportedOn"| 0
10 -->|"supportedOn"| 0
11 -->|"supportedOn"| 0
12 -->|"supportedOn"| 1
12 -->|"supportedOn"| 2
13 -->|"supportedOn"| 5
14 -->|"supportedOn"| 5
15 -->|"supportedOn"| 5
16 -->|"supportedOn"| 5
17 -->|"supportedOn"| 3
17 -->|"requiredModule"| 13
18 -->|"supportedOn"| 3
18 -->|"requiredModule"| 14
19 -->|"supportedOn"| 3
19 -->|"requiredModule"| 15
19 -->|"requiredModule"| 31
20 -->|"supportedOn"| 3
20 -->|"requiredModule"| 16
20 -->|"requiredModule"| 32
21 -->|"supportedOn"| 1
21 -->|"requiredModule"| 13
21 -->|"implies"| 17
22 -->|"supportedOn"| 1
22 -->|"requiredModule"| 14
22 -->|"implies"| 18
23 -->|"supportedOn"| 1
23 -->|"requiredModule"| 15
23 -->|"implies"| 19
24 -->|"supportedOn"| 1
24 -->|"requiredModule"| 16
24 -->|"implies"| 20
25 -->|"supportedOn"| 2
25 -->|"requiredModule"| 13
25 -->|"implies"| 17
26 -->|"supportedOn"| 2
26 -->|"requiredModule"| 14
26 -->|"implies"| 18
27 -->|"supportedOn"| 2
27 -->|"requiredModule"| 16
27 -->|"implies"| 20
28 -->|"supportedOn"| 2
28 -->|"requiredModule"| 15
28 -->|"requiredModule"| 14
28 -->|"implies"| 19
29 -->|"supportedOn"| 5
29 -->|"requiredModule"| 15
30 -->|"supportedOn"| 5
31 -->|"supportedOn"| 5
31 -->|"requiredModule"| 15
31 -->|"requiredModule"| 30
31 -->|"requiredModule"| 29
32 -->|"supportedOn"| 5
32 -->|"requiredModule"| 16
33 -->|"supportedOn"| 4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals/Scope
Adds
client-foldkitas a new target kind for scaffolding frontend client using foldkit. Introduces two new composition primitives (ts-object-field,namespaceImport) to support foldkit's pattern of deterministic AST-based module composition.Description
Domain (
@repo/domain)ts-object-fieldcontribution type toCatalog.ts— injects a property into an object literal argument of a function call (e.g.,Schema.Struct,M.tagsExhaustive)namespaceImportfield tots-call-arg,jsx-slot, and import operation schemas — enablesimport * as X from "..."patternsTsObjectFieldOptoPlan.tscomposition operationsScaffold (
@repo/scaffold)applyTsObjectFieldinTypeScriptComposer— finds variable → function call → object literal → adds property via ts-morphapplyTsAppendCallArg— correctly targets the outer () in patterns likeSubscription.aggregate<M, Msg>()()ContributionResolver,PlanAssessor,PlanService, andPlanRendererfor the new contribution typesCatalog (
@repo/catalog)client-foldkittarget definition (path: apps/client-foldkit-{name})http-api-foldkit-client,http-rpc-foldkit-client,ws-presence-foldkit-client,chat-foldkit-clientmain.ts,compose.ts,theme.ts,entry.ts, etc.) and all module features/servicesconfig-typescript-vitemodule to support client-foldkit kindComments
Modules compose into
main.tsviats-object-field(Model fields, update cases) andts-call-arg(Messageunion,Init.compose,Subscription.aggregate,Views.compose).Can see the template in its full on the block/foldkit branch
This is part 2 of 2 in a stack made with GitButler: