[dialects] Reorganize dialect extensions#86
Conversation
| sg_m, sg_n = layer_params["sg_m"], layer_params["sg_n"] | ||
|
|
||
| @td_smt_ext.constrain_params(wg_m, wg_n, sg_m, sg_n) | ||
| @smt_ext.constrain_params(wg_m, wg_n, sg_m, sg_n) |
There was a problem hiding this comment.
| @smt_ext.constrain_params(wg_m, wg_n, sg_m, sg_n) | |
| @td_ext_smt.constrain_params(wg_m, wg_n, sg_m, sg_n) |
I am chatting with @PragmaTwice to allow transform_ext.smt.constrain_params. We could also wait for that to merge upstream and change the above to @transform_ext.smt.constrain_params(...).
adam-smnk
changed the title
|
What's the status of this PR? |
|
All feedback has been addressed. It could land as it is % new conflicts with main. Or wait for the linked PR to land first. |
|
If there's a linked PR and you'll need to rebase anyway, just let that one merge and finish here. |
|
I don't recommend you to wait llvm/llvm-project#187911 because the new solution (requested by reviewers) requires more code changes, and I'm not sure when I'll have the time to finish it. |
|
Thanks for the update, @PragmaTwice Then I'd propose to rebase this PR on main and merge the current structure. |
Refactors transform extension dialects into separate submodules and places their definitions into separate files. The refactor aligns lighthouse dialect structure closer to upstream bindings mirroring its nesting. That also makes the op discovery easier and allows for cleaner addition of new extensions. When possible only the snake case op wrappers are exposed to promote their use which simplifies reuse across code and IR forms.
adam-smnk
force-pushed
the
transform-ext-refactor
branch
from
3de3b35 to
f3ebeb3
Compare
4 participants
Refactors dialect extensions into separate submodules and places their definitions into separate files.
The refactor aligns lighthouse dialect structure closer to upstream bindings mirroring its nesting. That also makes the op discovery easier and allows for cleaner addition of new extensions.
When possible only the snake case op wrappers are exposed to promote their use which simplifies reuse across code and IR forms.