[paolosalvatori]

Motivation

Running the web-app-cosmosdb-nosql-api sample from Git Bash on Windows fails at the Cosmos DB container step with Invalid partition key path found, and the script then carries on and deploys a web app whose container does not exist, as reported in SMF-963.
When Git Bash, or any other shell built on MSYS2, starts a Windows program such as the Azure CLI, it rewrites every argument that looks like an absolute POSIX path into a Windows path, so --partition-key-path /username reaches az as C:/Program Files/Git/username.
The same happens to the resource IDs the scripts pass to --scope or --ids and to the Front Door origin and probe paths, so the problem is not limited to one sample.
Our CI does not see it because it runs on Linux, where these arguments reach az unchanged.
Setting MSYS_NO_PATHCONV=1 turns the rewriting off, in Git Bash and in MSYS2 shells alike.
Git for Windows also cannot check out the repository at all, because of an empty file named ....

Fixes SMF-978

Changes

• README.md gets a "Windows: Git Bash and MSYS2" section under "Local Testing": it asks Windows users of these shells to run export MSYS_NO_PATHCONV=1, set -o igncr and export SHELLOPTS before any script, explains why, and covers making the setting permanent, recognizing these shells with $MSYSTEM, and turning the conversion back on.
• With the rewriting off, a Windows program no longer receives the Windows form of a local file, so every script that hands one to az, curl, jq, python or zip now passes it through a small native_path helper, which returns cygpath -m of the path in Git Bash and MSYS2 and the path unchanged everywhere else, so Linux, macOS and WSL behave exactly as before:
  • the temporary files read by curl and jq in the API Management, Front Door and URL shortener scripts;
  • the downloaded blob in function-app-managed-identity/python/scripts/test.sh;
  • the OpenAPI definition and policy in api-management-function-app/python/scripts/deploy.sh;
  • the Python checks the Event Hubs scripts run;
  • the function and dashboard archives the Event Hubs deployments build with zip, in the scripts, Bicep and Terraform variants (Git Bash ships no zip, and a zip.exe built for Windows needs the converted path too).
• For the same reason a Windows curl no longer receives /dev/null as the NUL device, so the 23 curl calls that discard a response body, in 11 scripts, pass it -o "$(null_device)": NUL for a Windows curl in Git Bash and MSYS2, /dev/null everywhere else, MSYS2's own curl under /usr/bin included. Without it, a Windows curl exited with code 23 on any response with a body, and the MySQL deploy scripts never left their readiness loop.
• Maven's mvn launcher is a shell script that hands its own paths to Java and relies on the conversion, so the three Service Bus deploy scripts run it as (unset MSYS_NO_PATHCONV; mvn ...); with the variable set, Java could not find Maven's launcher class.
• The README's tips tell script authors about both helpers and about such launchers.
• Windows programs such as the Azure CLI and jq end their lines with a carriage return, which Bash keeps in $(...) and read, so the README also asks for set -o igncr and export SHELLOPTS: the bash of Git Bash and MSYS2 then drops it. mapfile keeps the carriage return even then, so the App Configuration scripts, which read several fields at once with it, strip it with tr -d '\r'; without that, the sample failed on Windows with ResourceNotFound for a key vault whose ID carried the carriage return.
• The empty file named ... in samples/web-app-cosmosdb-nosql-api/python/scripts/ is removed: Git for Windows refuses to check out a path whose last component ends with a period, so a clone on Windows stopped with error: invalid path and left no working tree.
  The file arrived by accident in 0f07d42 and nothing references it.
• run-samples.sh registers samples/web-app-cosmosdb-nosql-api/python, the one sample variant with scripts that was missing from the list, next to its .NET counterpart, so CI also runs the variant this fix started from.

Tests

• bash -n on every edited script, and shellcheck reports the same findings as on main for each of them.
• The helper returns the path unchanged on Linux and the C:/... form when cygpath is on the PATH.
• null_device returns /dev/null without cygpath, NUL with cygpath and a native curl first on the PATH, and /dev/null with cygpath and /usr/bin/curl.
• git ls-tree finds no other path that Windows refuses: no name that ends with a period or a space, no reserved device name, no character such as :.
• The Samples CI of this pull request runs the changed samples on Linux.
• Windows is not covered by CI yet: Run all samples on a Windows runner from Git Bash #142 adds a manual Windows job built on this branch; its runs found the file named ... and the Maven launcher.

Related

• The same change for the AKS samples: Run the scripts from Git Bash and MSYS2 on Windows localstack-samples/aks-samples#47

🤖 Generated with Claude Code

https://claude.ai/code/session_01DhZ2ojsEXd2SGMo7s9uiZh

[Copilot]

🟡 Changes recommended

The upstream MSYS2 setup and remaining native Windows curl null-output paths leave Windows compatibility issues unresolved.

2 open issues

• Fix curl null-output paths for native Windows · New
• Set MSYS2_ARG_CONV_EXCL and document both variables · New

What changed in this PR

This PR improves Windows shell compatibility for the Azure samples by documenting path-conversion settings and explicitly converting local file paths passed to external tools.

Changes:

• Adds Git Bash and MSYS2 setup guidance.
• Converts temporary files, API definitions, Python script paths and archive destinations with native_path.
• Registers the Python Cosmos DB NoSQL sample in the shared sample runner.

File	Description
samples/​url-shortener/​python/​scripts/​validate.sh	Converts the downloaded QR file path.
samples/​function-app-managed-identity/​python/​scripts/​test.sh	Converts the blob download destination.
samples/​function-app-front-door/​python/​scripts/​validate.sh	Converts response temporary-file paths.
samples/​function-app-front-door/​python/​scripts/​call-front-door.sh	Converts response temporary-file paths.
samples/​eventhubs/​python/​terraform/​deploy.sh	Converts function and dashboard archive destinations.
samples/​eventhubs/​python/​scripts/​validate.sh	Converts Python check paths.
samples/​eventhubs/​python/​scripts/​run-pipeline.sh	Converts Python paths and the function archive destination.
samples/​eventhubs/​python/​scripts/​deploy.sh	Converts function and dashboard archive destinations.
samples/​eventhubs/​python/​bicep/​deploy.sh	Converts function and dashboard archive destinations.
samples/​eventhubs-eventgrid/​python/​terraform/​deploy.sh	Converts the processor archive destination.
samples/​eventhubs-eventgrid/​python/​scripts/​validate.sh	Converts the Python check path.
samples/​eventhubs-eventgrid/​python/​scripts/​run-pipeline.sh	Converts Python reader paths.
samples/​eventhubs-eventgrid/​python/​scripts/​deploy.sh	Converts the processor archive destination.
samples/​eventhubs-eventgrid/​python/​bicep/​deploy.sh	Converts the processor archive destination.
samples/​api-management-function-app/​python/​scripts/​validate.sh	Converts response temporary-file paths.
samples/​api-management-function-app/​python/​scripts/​deploy.sh	Converts the API definition and policy directory path.
samples/​api-management-function-app/​python/​scripts/​call-api.sh	Converts response temporary-file paths.
run-samples.sh	Registers the Python Cosmos DB NoSQL sample.
README.md	Documents Windows shell setup and path handling.

_{Review effort: Balanced}