fix: reject directory paths early in snapshot load#373
Merged
anisaoshafi merged 2 commits intoJul 22, 2026
Conversation
anisaoshafi
added
semver: patch
docs: skip
anisaoshafi
force-pushed
the
devx-954-fail-early-when-lstk-load-receives-a-directory
branch
from
July 21, 2026 16:27
a422ce2 to
d8d8447
Compare
anisaoshafi
force-pushed
the
devx-954-fail-early-when-lstk-load-receives-a-directory
branch
from
July 21, 2026 16:28
d8d8447 to
6f8ad6d
Compare
anisaoshafi
marked this pull request as ready for review
July 21, 2026 16:48
skyrpex
approved these changes
Jul 22, 2026
skyrpex
left a comment
skyrpex
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Thanks.
anisaoshafi
deleted the
devx-954-fail-early-when-lstk-load-receives-a-directory
branch
July 22, 2026 13:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lstk snapshot load accepted a directory path and let it fall through to the upload code path, where it failed with a confusing HTTP-layer error. Now it returns a clear "" is a directory, expected a snapshot file error when no file candidate resolves instead of silently treating a directory (e.g. . or ~/) as a valid local snapshot source.