Mention _.omit in _.pick and _.omitBy in _.pickBy documentation.#213
Closed
fmoessle wants to merge 2 commits intolodash:masterfrom
fmoessle:master
Closed
Mention _.omit in _.pick and _.omitBy in _.pickBy documentation.#213fmoessle wants to merge 2 commits intolodash:masterfrom fmoessle:master
fmoessle wants to merge 2 commits intolodash:masterfrom
fmoessle:master
Conversation
jdalton
reviewed
Aug 20, 2019
| <h3 id="pick"><a href="#pick" class="fa fa-link"></a><code>_.pick(object, [paths])</code></h3> | ||
| <p><a href="https://github.com/lodash/lodash/blob/4.17.15/lodash.js#L13559">source</a> <a href="https://www.npmjs.com/package/lodash.pick">npm package</a></p> | ||
| <p>Creates an object composed of the picked <code>object</code> properties.</p> | ||
| <p>The opposite of <a href="#omit"><code>_.omit</code></a>; creates an object composed of the picked <code>object</code> properties.</p> |
Member
There was a problem hiding this comment.
Can you make it align more with the omit flavor and do:
; this method creates
Member
|
These kinds of changes should target the JSDoc of lodash.js in the main lodash repo, so they are not overwritten when the docs are regenerated in the future. The docs are generatd from the JSDoc in the source. |
Member
|
Thank you, closing out as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mention _.omit in _.pick and _.omitBy in _.pickBy documentation.