Skip to content

Cleanup of rmsimage.py#289

Open
AlexKurek wants to merge 10 commits into
lofar-astron:masterfrom
AlexKurek:Minor-cleanup-of-rmsimage.py
Open

Cleanup of rmsimage.py#289
AlexKurek wants to merge 10 commits into
lofar-astron:masterfrom
AlexKurek:Minor-cleanup-of-rmsimage.py

Conversation

@AlexKurek
Copy link
Copy Markdown
Contributor

@AlexKurek AlexKurek commented Jun 1, 2026

  • max_isl_brightsize is never used.
  • mylog = mylogger.logging.getLogger("PyBDSF."+img.log+"Rmsimage.Calcmaps ") was a duplicate - the same line is 2 lines above.
  • thratio, avg_max_isl_size, maxrms, maxmean, pt_src_scale are computed but not used.

@AlexKurek
Copy link
Copy Markdown
Contributor Author

AlexKurek commented Jun 3, 2026

  • after removing the above variables also max_isl_size_lowthresh, bright_threshold, isl_snr, mask_small and isl_size_lowthresh are not needed
  • from . import _cbdsm is not used
  • from .image import Image, NArray, List is not used
  • moved floor, ceil import tothe top of the file

Changing the name of the PR, since its not longer so minor.

@AlexKurek AlexKurek changed the title Minor cleanup of rmsimage.py Cleanup of rmsimage.py Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant