chore(e2e-next): Migrate e2e_plugin to e2e-next framework#3701
chore(e2e-next): Migrate e2e_plugin to e2e-next framework#3701pascalbreuninger wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9008ad7b69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,5 +1,9 @@ | |||
| # Plugin Definition below. This is essentially a valid helm values file that will be merged | |||
| # with the other vcluster values during vcluster create or helm install. | |||
| controlPlane: | |||
There was a problem hiding this comment.
Keep migrated plugin values in e2e change detection
By moving this values file from test/e2e_plugin into e2e-next/clusters, plugin config changes are no longer covered by existing CI path filters: in .github/workflows/e2e.yaml the detect_changes paths explicitly exclude e2e-next/** (line 33), and in .github/workflows/e2e-ginkgo.yaml the filter includes **.go and test/** but not e2e-next/**/*.yaml (lines 81-87). That means a YAML-only change here can skip both e2e workflows and let plugin regressions merge untested, so the workflow path filters should be updated as part of this migration.
Useful? React with 👍 / 👎.
Summary
test/e2e_plugin/(plugin tests) toe2e-next/test_plugin/PluginVClustercluster definition with dedicated values YAML preserving all plugin configse2e_suite_test.gowith proper setup/cleanup wiringTest plan
go build ./e2e-next/...compiles cleanlygo vet ./e2e-next/...passestest/e2e_plugin/files are fully removed🤖 Generated with Claude Code
📋 E2E Migration Validator Notes
Overall: ✅ Approved with suggestions
🟡 Should Fix
hostSvc.Spec.Ports[1]is the plugin port. While carried over from the old test and likely stable in practice, aContainElement-based matcher would be more resilient to API server reordering.🟢 Nice to Have
test/testas the import destination. Not a regression (old test same), but would collide if parallelized within the same vcluster.GinkgoRandomSeed()for isolation — good improvement over old hardcoded names.