Skip to content

chore(e2e-next): Migrate e2e_plugin to e2e-next framework#3701

Open
pascalbreuninger wants to merge 1 commit intomainfrom
migrate/e2e-plugin-to-e2e-next
Open

chore(e2e-next): Migrate e2e_plugin to e2e-next framework#3701
pascalbreuninger wants to merge 1 commit intomainfrom
migrate/e2e-plugin-to-e2e-next

Conversation

@pascalbreuninger
Copy link
Copy Markdown
Member

Summary

  • Migrates test/e2e_plugin/ (plugin tests) to e2e-next/test_plugin/
  • Covers all three original tests: bootstrap-with-deployment, hooks port injection, import-secrets lifecycle
  • Adds PluginVCluster cluster definition with dedicated values YAML preserving all plugin configs
  • Registers suite in e2e_suite_test.go with proper setup/cleanup wiring

Test plan

  • go build ./e2e-next/... compiles cleanly
  • go vet ./e2e-next/... passes
  • Run plugin e2e suite against a kind cluster
  • Verify old test/e2e_plugin/ files are fully removed

🤖 Generated with Claude Code


📋 E2E Migration Validator Notes

Overall: ✅ Approved with suggestions

🟡 Should Fix

  • Port ordering assumption (line 87-89): The hooks test asserts hostSvc.Spec.Ports[1] is the plugin port. While carried over from the old test and likely stable in practice, a ContainElement-based matcher would be more resilient to API server reordering.

🟢 Nice to Have

  • Fixed import target name: The import-secrets test uses hardcoded test/test as the import destination. Not a regression (old test same), but would collide if parallelized within the same vcluster.
  • Resource names use GinkgoRandomSeed() for isolation — good improvement over old hardcoded names.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9008ad7b69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,5 +1,9 @@
# Plugin Definition below. This is essentially a valid helm values file that will be merged
# with the other vcluster values during vcluster create or helm install.
controlPlane:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep migrated plugin values in e2e change detection

By moving this values file from test/e2e_plugin into e2e-next/clusters, plugin config changes are no longer covered by existing CI path filters: in .github/workflows/e2e.yaml the detect_changes paths explicitly exclude e2e-next/** (line 33), and in .github/workflows/e2e-ginkgo.yaml the filter includes **.go and test/** but not e2e-next/**/*.yaml (lines 81-87). That means a YAML-only change here can skip both e2e workflows and let plugin regressions merge untested, so the workflow path filters should be updated as part of this migration.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant