Changes for CI tests and code clean up

.github/workflows/test_docker.yml

@@ -1,4 +1,4 @@
-# Run tests on Fedora and Ubuntu Docker images using GIFT CORP and GIFT PPA on commit
+# Run tests on Fedora and Ubuntu Docker images using GIFT COPR and GIFT PPA on commit
 name: test_docker
 on: [push]
 permissions: read-all
@@ -11,7 +11,7 @@ jobs:
     container:
       image: registry.fedoraproject.org/fedora:${{ matrix.version }}
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up container
       run: |
         dnf install -y dnf-plugins-core langpacks-en
@@ -41,7 +41,7 @@ jobs:
     container:
       image: ubuntu:${{ matrix.version }}
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up container
       env:
         DEBIAN_FRONTEND: noninteractive

.github/workflows/test_docs.yml

@@ -1,4 +1,4 @@
-# Run docs tox tests on Ubuntu Docker images using GIFT PPA
+# Run docs tox tests on Ubuntu Docker images using the deadsnakes and GIFT PPAs
 name: test_docs
 on:
   pull_request:
@@ -13,13 +13,11 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        include:
-        - python-version: '3.12'
-          toxenv: 'docs'
+        python-version: ['3.12']
     container:
       image: ubuntu:24.04
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up container
       env:
         DEBIAN_FRONTEND: noninteractive
@@ -41,4 +39,4 @@ jobs:
       env:
         LANG: en_US.UTF-8
       run: |
-        tox -e${{ matrix.toxenv }}
+        tox -e docs

.github/workflows/test_macos.yml

@@ -12,7 +12,7 @@ jobs:
           python-version: '3.14'
           toxenv: 'py314'
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v6
     - name: Install dependencies
       run: |
         brew update -q

.github/workflows/test_tox.yml

@@ -1,4 +1,4 @@
-# Run tox tests on Ubuntu Docker images using GIFT PPA
+# Run tox tests on Ubuntu Docker images using the deadsnakes and GIFT PPAs
 name: test_tox
 on:
   pull_request:
@@ -15,19 +15,19 @@ jobs:
       matrix:
         include:
         - python-version: '3.10'
-          toxenv: 'py310,wheel'
+          toxenv: 'py310'
         - python-version: '3.11'
-          toxenv: 'py311,wheel'
+          toxenv: 'py311'
         - python-version: '3.12'
-          toxenv: 'py312,wheel'
+          toxenv: 'py312'
         - python-version: '3.13'
-          toxenv: 'py313,wheel'
+          toxenv: 'py313'
         - python-version: '3.14'
-          toxenv: 'py314,wheel'
+          toxenv: 'py314'
     container:
       image: ubuntu:24.04
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up container
       env:
         DEBIAN_FRONTEND: noninteractive
@@ -49,18 +49,16 @@ jobs:
       env:
         LANG: en_US.UTF-8
       run: |
-        tox -e${{ matrix.toxenv }}
+        tox -e ${{ matrix.toxenv }},wheel
   coverage:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        include:
-        - python-version: '3.12'
-          toxenv: 'coverage'
+        python-version: ['3.12']
     container:
       image: ubuntu:24.04
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up container
       env:
         DEBIAN_FRONTEND: noninteractive
@@ -77,27 +75,25 @@ jobs:
         add-apt-repository -y ppa:deadsnakes/ppa
         add-apt-repository -y ppa:gift/dev
         apt-get update -q
-        apt-get install -y build-essential git pkg-config python${{ matrix.python-version }} python${{ matrix.python-version }}-dev python${{ matrix.python-version }}-venv python3-pip python3-setuptools tox
+        apt-get install -y build-essential curl git pkg-config python${{ matrix.python-version }} python${{ matrix.python-version }}-dev python${{ matrix.python-version }}-venv python3-pip python3-setuptools tox
     - name: Run tests with coverage
       env:
         LANG: en_US.UTF-8
       run: |
-        tox -e${{ matrix.toxenv }}
+        tox -e coverage
     - name: Upload coverage report to Codecov
-      uses: codecov/codecov-action@v4
+      uses: codecov/codecov-action@v6
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
   lint:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        include:
-        - python-version: '3.12'
-          toxenv: 'lint'
+        python-version: ['3.12']
     container:
       image: ubuntu:24.04
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up container
       env:
         DEBIAN_FRONTEND: noninteractive
@@ -119,4 +115,4 @@ jobs:
       env:
         LANG: en_US.UTF-8
       run: |
-        tox -e${{ matrix.toxenv }}
+        tox -e lint

.pylintrc

@@ -449,7 +449,6 @@ confidence=HIGH,
 # --disable=W".
 disable=assignment-from-none,
         bad-inline-option,
-        consider-using-f-string,
         deprecated-pragma,
         duplicate-code,
         file-ignored,

dfdatetime/cocoa_time.py

@@ -93,7 +93,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     timestamp = self._GetNumberOfSecondsFromElements(
         year, month, day_of_month, hours, minutes, seconds)

dfdatetime/delphi_date_time.py

@@ -98,7 +98,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     if year > 9999:
       raise ValueError(f'Unsupported year value: {year:d}.')

dfdatetime/dotnet_datetime.py

@@ -94,7 +94,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     if year > 9999:
       raise ValueError(f'Unsupported year value: {year:d}.')

dfdatetime/fake_time.py

@@ -80,8 +80,8 @@ def CopyFromDateTimeString(self, time_string):
     hours = date_time_values.get('hours', 0)
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
-    nanoseconds = date_time_values.get('nanoseconds', None)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    nanoseconds = date_time_values.get('nanoseconds')
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     self._normalized_timestamp = None
     self._number_of_seconds = self._GetNumberOfSecondsFromElements(

dfdatetime/fat_date_time.py

@@ -154,7 +154,7 @@ def CopyFromDateTimeString(self, time_string):
     hours = date_time_values.get('hours', 0)
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     if year < 1980 or year > (1980 + 0x7f):
       raise ValueError(f'Year value not supported: {year!s}.')
@@ -265,7 +265,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     if year < 1980 or year > (1980 + 0x7f):
       raise ValueError(f'Year value not supported: {year!s}.')

dfdatetime/filetime.py

@@ -98,7 +98,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     if year < 1601:
       raise ValueError(f'Year value not supported: {year!s}.')

dfdatetime/golang_time.py

@@ -175,7 +175,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     if year < 0:
       raise ValueError(f'Year value not supported: {year!s}.')

dfdatetime/hfs_time.py

@@ -94,7 +94,7 @@ def CopyFromDateTimeString(self, time_string):
     hours = date_time_values.get('hours', 0)
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     if year < 1904 or year > 2040:
       raise ValueError('Year value not supported.')

dfdatetime/interface.py

@@ -746,7 +746,7 @@ def _GetNumberOfDaysInCentury(self, year):
     year, _ = divmod(year, 100)
     year *= 100
 
-    number_of_days = definitions.DAYS_PER_CENTURY.get(year, None)
+    number_of_days = definitions.DAYS_PER_CENTURY.get(year)
     if number_of_days is not None:
       return number_of_days
 
@@ -763,7 +763,7 @@ def _GetNumberOfDaysInYear(self, year):
     Returns:
       int: number of days in the year.
     """
-    number_of_days = definitions.DAYS_PER_YEAR.get(year, None)
+    number_of_days = definitions.DAYS_PER_YEAR.get(year)
     if number_of_days is not None:
       return number_of_days
 
@@ -809,7 +809,7 @@ def _GetNumberOfSecondsFromElements(
     elif seconds not in range(0, 60):
       raise ValueError(f'Seconds value: {seconds!s} out of bounds.')
 
-    number_of_days = definitions.DAYS_PER_YEAR_IN_POSIX_EPOCH.get(year, None)
+    number_of_days = definitions.DAYS_PER_YEAR_IN_POSIX_EPOCH.get(year)
     if number_of_days is None:
       raise ValueError(f'Year value: {year!s} out of bounds.')
 
@@ -896,7 +896,7 @@ def CopyToPosixTimestampWithFractionOfSecond(self):
     if normalized_timestamp is None:
       return None, None
 
-    remainder_multiplier = self._REMAINDER_MULTIPLIER.get(self._precision, None)
+    remainder_multiplier = self._REMAINDER_MULTIPLIER.get(self._precision)
     if not remainder_multiplier:
       remainder = None
     elif normalized_timestamp >= 0:

dfdatetime/ole_automation_date.py

@@ -99,7 +99,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     timestamp = self._GetNumberOfSecondsFromElements(
         year, month, day_of_month, hours, minutes, seconds)

dfdatetime/posix_time.py

@@ -89,7 +89,7 @@ def CopyFromDateTimeString(self, time_string):
     hours = date_time_values.get('hours', 0)
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     self._timestamp = self._GetNumberOfSecondsFromElements(
         year, month, day_of_month, hours, minutes, seconds)
@@ -187,7 +187,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     milliseconds, _ = divmod(
         nanoseconds, definitions.NANOSECONDS_PER_MILLISECOND)
@@ -293,7 +293,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     milliseconds, _ = divmod(
         nanoseconds, definitions.NANOSECONDS_PER_MICROSECOND)
@@ -399,7 +399,7 @@ def _CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     timestamp = self._GetNumberOfSecondsFromElements(
         year, month, day_of_month, hours, minutes, seconds)

dfdatetime/precisions.py

@@ -394,7 +394,7 @@ def CreatePrecisionHelper(cls, precision):
     Raises:
       ValueError: if the precision value is unsupported.
     """
-    precision_helper_class = cls._PRECISION_CLASSES.get(precision, None)
+    precision_helper_class = cls._PRECISION_CLASSES.get(precision)
     if not precision_helper_class:
       raise ValueError(f'Unsupported precision: {precision!s}')
 

dfdatetime/rfc2579_date_time.py

@@ -208,7 +208,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     deciseconds, _ = divmod(
         nanoseconds, definitions.NANOSECONDS_PER_DECISECOND)

dfdatetime/serializer.py

@@ -183,7 +183,7 @@ def ConvertJSONToDateTimeValues(cls, json_dict):
     Returns:
       dfdatetime.DateTimeValues: date and time values.
     """
-    class_name = json_dict.get('__class_name__', None)
+    class_name = json_dict.get('__class_name__')
     if class_name:
       del json_dict['__class_name__']
 
@@ -193,25 +193,25 @@ def ConvertJSONToDateTimeValues(cls, json_dict):
     if class_name not in (
         'TimeElements', 'TimeElementsInMilliseconds',
         'TimeElementsInMicroseconds'):
-      is_delta = json_dict.get('is_delta', None)
+      is_delta = json_dict.get('is_delta')
       if is_delta is not None:
         del json_dict['is_delta']
 
-    is_local_time = json_dict.get('is_local_time', None)
+    is_local_time = json_dict.get('is_local_time')
     if is_local_time is not None:
       del json_dict['is_local_time']
 
-    time_zone_hint = json_dict.get('time_zone_hint', None)
+    time_zone_hint = json_dict.get('time_zone_hint')
     if time_zone_hint is not None:
       del json_dict['time_zone_hint']
 
     if class_name in ('InvalidTime', 'Never', 'NotSet'):
-      string = json_dict.get('string', None)
+      string = json_dict.get('string')
       if string is not None:
         del json_dict['string']
 
     if class_name in ('GolangTime', 'RFC2579DateTime'):
-      time_zone_offset = json_dict.get('time_zone_offset', None)
+      time_zone_offset = json_dict.get('time_zone_offset')
       if time_zone_offset is not None:
         del json_dict['time_zone_offset']
 

dfdatetime/systemtime.py

@@ -183,7 +183,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', None)
+    time_zone_offset = date_time_values.get('time_zone_offset')
 
     milliseconds, _ = divmod(
         nanoseconds, definitions.NANOSECONDS_PER_MILLISECOND)