Skip to content

[FSTORE-1793] Logger messages increasing latency for during fetching feature vectors.#1433

Merged
SirOibaf merged 3 commits into
logicalclocks:branch-3.9from
manu-sj:FSTORE-1793
Jul 21, 2025
Merged

[FSTORE-1793] Logger messages increasing latency for during fetching feature vectors.#1433
SirOibaf merged 3 commits into
logicalclocks:branch-3.9from
manu-sj:FSTORE-1793

Conversation

@manu-sj
Copy link
Copy Markdown
Contributor

@manu-sj manu-sj commented Jul 10, 2025

The PR fixes an issue in which a increase in latency was observed during fetching feature vectors.

Root Cause:
The function handle_rdrs_feature_store_response was taking a CPU because the logger message was getting created even if the message was not printed.

Fix Done
Add if conditions to check the logger messages before it is printed.

JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1793

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@manu-sj manu-sj changed the base branch from master to branch-3.9 July 10, 2025 09:07
@manu-sj manu-sj requested a review from SirOibaf July 10, 2025 09:20
@SirOibaf SirOibaf merged commit 91ed026 into logicalclocks:branch-3.9 Jul 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants