[FSTORE-1800] Add support for pojo objects in flink client#1435
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for POJO objects in the Flink client by refactoring POJO-to-Avro conversion logic. The changes centralize the conversion logic into a shared utility class and update the Flink engine to use this common implementation.
Key changes:
- Extract POJO-to-Avro conversion logic from Engine.java into a shared utility class
- Refactor Flink engine to use the centralized conversion logic
- Update version numbers across all modules to 3.9.0-RC22
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| java/hsfs/src/main/java/com/logicalclocks/hsfs/engine/PojoToAvroUtils.java | New utility class containing extracted POJO-to-Avro conversion logic |
| java/hsfs/src/main/java/com/logicalclocks/hsfs/engine/Engine.java | Refactored to use PojoToAvroUtils instead of inline conversion methods |
| java/flink/src/main/java/com/logicalclocks/hsfs/flink/engine/PojoToAvroRecord.java | Simplified to use PojoToAvroUtils for conversion |
| java/flink/src/main/java/com/logicalclocks/hsfs/flink/engine/FlinkEngine.java | Updated to pass schema strings instead of deserialized schemas |
| Multiple pom.xml files | Version bumps from 3.9.0-RC21 to 3.9.0-RC22 |
| python/hsfs/version.py | Python version bump to match Java version |
manu-sj
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds/fixes/changes...
JIRA Issue: -
Priority for Review: -
Related PRs: -
How Has This Been Tested?
Checklist For The Assigned Reviewer: