Conversation
simeng-li
requested review from
charIeszhao,
gao-sun,
wangsijie and
xiaoyijun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/bright-pencils-add.md | 📈 +752 Bytes |
| .changeset/clean-dolphins-wave.md | 📈 +439 Bytes |
| packages/console/src/pages/UserDetails/UserSettings/index.tsx | 📈 +79 Bytes |
| packages/core/src/routes/account/grants.ts | 📈 +110 Bytes |
| packages/core/src/routes/account/index.openapi.json | 📈 +66 Bytes |
| packages/core/src/routes/account/index.ts | 📈 +99 Bytes |
| packages/core/src/routes/admin-user/grants.openapi.json | 📈 +66 Bytes |
| packages/core/src/routes/admin-user/grants.ts | 📈 +110 Bytes |
| packages/integration-tests/src/tests/api/account/grants.test.ts | 📈 +63 Bytes |
| packages/integration-tests/src/tests/api/sessions/index.test.ts | 📈 +93 Bytes |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes third-party app grant management generally available by removing the isDevFeaturesEnabled guard across core APIs and the console UI, and updates integration tests + changesets accordingly.
Changes:
- Removed
EnvSet.values.isDevFeaturesEnabledgating from Management API and Account API user-grants routes. - Exposed the “Authorized third-party apps” section in Console user details without a dev-feature toggle.
- Updated integration tests to run grant-management test cases unconditionally; added changesets for core/console.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/integration-tests/src/tests/api/sessions/index.test.ts | Runs user-grant management tests without devFeatureTest gating. |
| packages/integration-tests/src/tests/api/account/grants.test.ts | Runs account-center grant management tests without devFeatureTest gating. |
| packages/core/src/routes/admin-user/grants.ts | Removes dev-feature early-return so Management API grant endpoints are always registered. |
| packages/core/src/routes/account/index.ts | Always registers accountGrantRoutes (no dev-feature conditional). |
| packages/core/src/routes/account/grants.ts | Removes dev-feature early-return so Account API grant endpoints are always registered. |
| packages/console/src/pages/UserDetails/UserSettings/index.tsx | Always renders UserThirdPartyApps section (no dev-feature conditional). |
| .changeset/clean-dolphins-wave.md | Console release note for the third-party app authorizations section. |
| .changeset/bright-pencils-add.md | Core release note for grant-management endpoints and appType filtering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
remove dev feature guard for user grants management
add changeset
remove dev feature tag from api doc
simeng-li
force-pushed
the
simeng-log-13069-remove-third-party-grant-management-dev-guard
branch
from
c500070 to
2ff6e34
Compare
gao-sun
approved these changes
Mar 30, 2026
simeng-li
deleted the
simeng-log-13069-remove-third-party-grant-management-dev-guard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the dev feature guard for third-party app grants management. Changeset added.
Testing
Checklist
.changeset