Conversation
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/fancy-mangoes-drum.md | 📉 -847 Bytes |
| .changeset/small-rings-care.md | 📉 -720 Bytes |
| .changeset/tasty-years-approve.md | 📉 -647 Bytes |
| packages/console/src/containers/ConsoleContent/Sidebar/hook.tsx | 📉 -371 Bytes |
| packages/console/src/hooks/use-console-routes/index.tsx | 📉 -251 Bytes |
| packages/console/src/hooks/use-console-routes/routes/tenant-settings.tsx | 📉 -58 Bytes |
| packages/console/src/pages/SigningKeys/SigningKeyFormCard/index.module.scss | 📉 -667 Bytes |
| packages/console/src/pages/SigningKeys/SigningKeyFormCard/index.tsx | 📉 -6.29 KB |
| packages/console/src/pages/SigningKeys/index.module.scss | 📉 -195 Bytes |
| packages/console/src/pages/SigningKeys/index.tsx | 📉 -1.05 KB |
| packages/console/src/pages/TenantSettings/index.tsx | 📉 -105 Bytes |
| packages/core/src/oidc/init.ts | 📉 -80 Bytes |
| packages/core/src/routes/logto-config/index.ts | 📉 -42 Bytes |
| packages/core/src/routes/logto-config/logto-config.openapi.json | 📉 -66 Bytes |
| packages/core/src/routes/swagger/utils/operation-id.ts | 📉 -135 Bytes |
| packages/integration-tests/src/tests/api/logto-config.test.ts | 📉 -63 Bytes |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes tenant-level OIDC session configuration (notably session TTL) generally available by removing dev-feature gating across the API, provider initialization, and console navigation, while also removing the legacy “Signing keys” page in favor of the consolidated Tenant Settings → OIDC settings experience.
Changes:
- Enable OIDC session config management endpoints and related integration tests outside dev-feature gating.
- Apply
oidc.session.ttlduring OIDC provider initialization (no dev-feature guard). - Remove the legacy Signing Keys page/route and expose OIDC configs under Tenant Settings for both Cloud and OSS consoles.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/integration-tests/src/tests/api/logto-config.test.ts | Runs OIDC session config integration tests unconditionally (no dev-feature wrapper). |
| packages/core/src/routes/logto-config/logto-config.openapi.json | Removes “Dev feature” tagging from session config endpoints in the OpenAPI spec. |
| packages/core/src/routes/logto-config/index.ts | Makes /configs/oidc/session GET/PATCH always available (no EnvSet dev-feature gate). |
| packages/core/src/oidc/init.ts | Uses configured session TTL from env-set OIDC values (no dev-feature guard). |
| packages/console/src/pages/TenantSettings/index.tsx | Always shows the OIDC configs tab in Tenant Settings (no dev-feature gate). |
| packages/console/src/pages/SigningKeys/index.tsx | Removes the deprecated Signing Keys page. |
| packages/console/src/pages/SigningKeys/index.module.scss | Removes Signing Keys page styles. |
| packages/console/src/pages/SigningKeys/SigningKeyFormCard/index.tsx | Removes the deprecated signing key management card component. |
| packages/console/src/pages/SigningKeys/SigningKeyFormCard/index.module.scss | Removes signing key card styles. |
| packages/console/src/hooks/use-console-routes/routes/tenant-settings.tsx | Always exposes Tenant Settings routes for OSS and always includes OIDC configs tab for Cloud. |
| packages/console/src/hooks/use-console-routes/index.tsx | Removes the signing-keys route from the console router. |
| packages/console/src/containers/ConsoleContent/Sidebar/hook.tsx | Removes the “Signing keys” sidebar item and makes Tenant section always visible. |
| .changeset/tasty-years-approve.md | Adds a schemas release note for optional oidc.session.ttl. |
| .changeset/small-rings-care.md | Adds console release notes about Tenant Settings + OIDC settings migration. |
| .changeset/fancy-mangoes-drum.md | Adds core release notes about configurable session TTL and new management APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wangsijie
approved these changes
Mar 29, 2026
c500070 to
2ff6e34
Compare
95d5aa7 to
cb5dfbe
Compare
gao-sun
approved these changes
Mar 30, 2026
Base automatically changed from
simeng-log-13069-remove-third-party-grant-management-dev-guard
to
master
March 30, 2026 03:24
remove dev feature guard
add changeset
clean up legacy signing keys page
fix the broken generation API operation ID
add fallback redirect navigation for legacy signing-keys url
refactor configs/oidc/sessions response guard
cb5dfbe to
68ad6b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the tenant-level OIDC/session configuration feature fully available by removing dev-feature gating, and cleans up legacy signing-key management UX.
Testing
Checklist
.changeset