Skip to content

chore(console, core): remove dev feature guard for session TTL#8572

Merged
simeng-li merged 6 commits intomasterfrom
simeng-log-13067-remove-session-ttl-dev-feature-guard
Mar 30, 2026
Merged

chore(console, core): remove dev feature guard for session TTL#8572
simeng-li merged 6 commits intomasterfrom
simeng-log-13067-remove-session-ttl-dev-feature-guard

Conversation

@simeng-li
Copy link
Copy Markdown
Contributor

Summary

This PR makes the tenant-level OIDC/session configuration feature fully available by removing dev-feature gating, and cleans up legacy signing-key management UX.

  • Removed dev feature guards from the relevant OIDC/session configuration flow, so the functionality is now active in normal environments.
  • Enabled the end-to-end feature path (UI + API + provider config usage) as a standard capability instead of a dev-only path.
  • Cleaned up legacy tenant signing key management by deprecating/removing the old Signing Keys page and consolidating configuration under Tenant Settings.

Testing

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2026

COMPARE TO master

Total Size Diff 📉 -6.41 KB

Diff by File
Name Diff
.changeset/fancy-mangoes-drum.md 📉 -847 Bytes
.changeset/small-rings-care.md 📉 -720 Bytes
.changeset/tasty-years-approve.md 📉 -647 Bytes
packages/console/src/containers/ConsoleContent/Sidebar/hook.tsx 📉 -371 Bytes
packages/console/src/hooks/use-console-routes/index.tsx 📉 -251 Bytes
packages/console/src/hooks/use-console-routes/routes/tenant-settings.tsx 📉 -58 Bytes
packages/console/src/pages/SigningKeys/SigningKeyFormCard/index.module.scss 📉 -667 Bytes
packages/console/src/pages/SigningKeys/SigningKeyFormCard/index.tsx 📉 -6.29 KB
packages/console/src/pages/SigningKeys/index.module.scss 📉 -195 Bytes
packages/console/src/pages/SigningKeys/index.tsx 📉 -1.05 KB
packages/console/src/pages/TenantSettings/index.tsx 📉 -105 Bytes
packages/core/src/oidc/init.ts 📉 -80 Bytes
packages/core/src/routes/logto-config/index.ts 📉 -42 Bytes
packages/core/src/routes/logto-config/logto-config.openapi.json 📉 -66 Bytes
packages/core/src/routes/swagger/utils/operation-id.ts 📉 -135 Bytes
packages/integration-tests/src/tests/api/logto-config.test.ts 📉 -63 Bytes

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes tenant-level OIDC session configuration (notably session TTL) generally available by removing dev-feature gating across the API, provider initialization, and console navigation, while also removing the legacy “Signing keys” page in favor of the consolidated Tenant Settings → OIDC settings experience.

Changes:

  • Enable OIDC session config management endpoints and related integration tests outside dev-feature gating.
  • Apply oidc.session.ttl during OIDC provider initialization (no dev-feature guard).
  • Remove the legacy Signing Keys page/route and expose OIDC configs under Tenant Settings for both Cloud and OSS consoles.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/integration-tests/src/tests/api/logto-config.test.ts Runs OIDC session config integration tests unconditionally (no dev-feature wrapper).
packages/core/src/routes/logto-config/logto-config.openapi.json Removes “Dev feature” tagging from session config endpoints in the OpenAPI spec.
packages/core/src/routes/logto-config/index.ts Makes /configs/oidc/session GET/PATCH always available (no EnvSet dev-feature gate).
packages/core/src/oidc/init.ts Uses configured session TTL from env-set OIDC values (no dev-feature guard).
packages/console/src/pages/TenantSettings/index.tsx Always shows the OIDC configs tab in Tenant Settings (no dev-feature gate).
packages/console/src/pages/SigningKeys/index.tsx Removes the deprecated Signing Keys page.
packages/console/src/pages/SigningKeys/index.module.scss Removes Signing Keys page styles.
packages/console/src/pages/SigningKeys/SigningKeyFormCard/index.tsx Removes the deprecated signing key management card component.
packages/console/src/pages/SigningKeys/SigningKeyFormCard/index.module.scss Removes signing key card styles.
packages/console/src/hooks/use-console-routes/routes/tenant-settings.tsx Always exposes Tenant Settings routes for OSS and always includes OIDC configs tab for Cloud.
packages/console/src/hooks/use-console-routes/index.tsx Removes the signing-keys route from the console router.
packages/console/src/containers/ConsoleContent/Sidebar/hook.tsx Removes the “Signing keys” sidebar item and makes Tenant section always visible.
.changeset/tasty-years-approve.md Adds a schemas release note for optional oidc.session.ttl.
.changeset/small-rings-care.md Adds console release notes about Tenant Settings + OIDC settings migration.
.changeset/fancy-mangoes-drum.md Adds core release notes about configurable session TTL and new management APIs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/console/src/hooks/use-console-routes/routes/tenant-settings.tsx Outdated
Comment thread packages/console/src/hooks/use-console-routes/index.tsx
Comment thread packages/core/src/routes/logto-config/index.ts Outdated
Comment thread packages/core/src/routes/logto-config/index.ts
@github-actions github-actions Bot added size/l and removed size/l labels Mar 27, 2026
@simeng-li simeng-li force-pushed the simeng-log-13069-remove-third-party-grant-management-dev-guard branch from c500070 to 2ff6e34 Compare March 30, 2026 02:47
@simeng-li simeng-li force-pushed the simeng-log-13067-remove-session-ttl-dev-feature-guard branch from 95d5aa7 to cb5dfbe Compare March 30, 2026 02:47
@github-actions github-actions Bot added size/xl and removed size/l labels Mar 30, 2026
Base automatically changed from simeng-log-13069-remove-third-party-grant-management-dev-guard to master March 30, 2026 03:24
@github-actions github-actions Bot added size/xl and removed size/xl labels Mar 30, 2026
add changeset
clean up legacy signing keys page
fix the broken generation API operation ID
add fallback redirect navigation for legacy signing-keys url
refactor configs/oidc/sessions response guard
@simeng-li simeng-li force-pushed the simeng-log-13067-remove-session-ttl-dev-feature-guard branch from cb5dfbe to 68ad6b8 Compare March 30, 2026 03:25
@github-actions github-actions Bot removed the size/xl label Mar 30, 2026
@simeng-li simeng-li merged commit 5b7f1cb into master Mar 30, 2026
42 of 43 checks passed
@simeng-li simeng-li deleted the simeng-log-13067-remove-session-ttl-dev-feature-guard branch March 30, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants