table: pass click modifiers through SelectRow event#2231
Conversation
|
Duplicate PR #2232? |
|
Not a duplicate of #2232. These are separate changes:
#2232 depends on this PR because both touch |
SelectRow now carries Modifiers so consumers can implement Cmd+click / Shift+click multi-select without intercepting mouse events on the row div (which breaks on_drag on children). Also adds set_parent_menu() on PopupMenu for external submenu wiring. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
19bb64c to
16646ec
Compare
|
Closing in favor of using GPUI's existing Consumers of Verified locally — multi-row selection works as expected. Closing #2228 alongside. |
Fixes #2228
Summary
SelectRow(usize)toSelectRow(usize, Modifiers)to carry keyboard modifiers from the click eventset_selected_row_with_modifiers()alongside the existingset_selected_row()(which passes default modifiers)on_dragon child elements)AI Disclosure
This code was generated with AI assistance (Claude). The implementation has been manually tested in a production GPUI application with multi-row selection and native macOS drag.