Repository navigation
test(workspace): qualify delegation scope through contextual help - #7317
Conversation
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent | gpt-6.1-sol | OpenAI | runtime_reported | reasoning_effort=max
APPROVE — c181338c04627f22cc74f4c60a645f1414dc17e0:独立复现旧断言误报,完整当前打包场景通过,针对实际产品语义的变异仍会失败。无阻塞发现。
动机
维护者运行团队执行验收时,旧场景等待已收进帮助控件的委派范围段落,实际界面正常也会超时。
同一个六条委派页面上,旧测试直接等待隐藏正文;新测试确认可见计数,打开“委派记录范围”,读完整限制,再关闭并回到原按钮。
本轮旧场景在隐藏段落准确失败,当前完整打包场景通过;仅把可见范围正文改错后,新场景也在目标说明断言失败。
本 PR 只修复既有浏览器验收,不改团队权限、执行分类、生产界面或模型调用,也不声称真实团队采用已验收。
这里验收的是已有维护任务:让测试按真实用户入口获取信息,同时继续拒绝错误含义。删除说明或保留失效的表现假设都不能完成这个目标。goal_achieved 仅指本次有界断言修复,不是整个产品、发布或长期效果已达成。
改动思路
接受的规格先于实现:docs/development/design.md,不可变实际 merge base f094b2cfb2acde7a4a0d4d875bba52f64ac31ba9,原文条目 Explanations On Demand。辅助说明应通过现有可访问入口完整读取,Escape 和焦点回返有效;打开帮助只读取,不启动模型或授予权限。另按同版本 docs/development/good-smokes.md 的 Prefer Semantic Pressure / 优先验证语义压力 与 Consolidate Without Losing Coverage / 合并时不丢失覆盖 判断保留价值,不能仅因跑通就保留样板。
Thirteen inline lines stay in the existing scenario; no helper or framework introduced. Extracting a one-use flow now adds indirection without a demonstrated shared owner. 产品判断继续由原来的 owner 承担,测试只观察真实入口。源码路径是 Existing fixture operations -> shipped GoalTeamWork counts/scope -> existing ContextHelp -> current full loopx-mode scenario.;没有新状态、配置、能力或控制面决策 owner。两个提案共享接受基线 f094;验证包从当前完整前端源码重新 build,再确认每个 base/head 的生产源码及打包字节相同,并分别做 source-bundle 验证。
具体改动
One existing mjs +13/-1; changes only the stale paragraph assertion and actual accessible interaction. 完整差异已逐项读过,不把未改的生产界面重述为新功能。关键路径与正反执行如下。
loopx-mode.mjs:132–144 先确认可见“6 条委派”,再点击精确命名的帮助,读取整句“本页 6 条委派记录,仅限当前协调身份;分页不是团队快照。”;关闭后检查 tooltip 隐藏、焦点在原按钮,且 api.turnRequests 没有增加。不是只匹配按钮名或把范围段落删掉。后续同 Agent 不同任务的记录分组、历史/缺任务/未知/恢复、证据入口及移动端断言保持原样。
生产来源是 goal-team-work.tsx:191,它把当前页计数与 coordinator/pagination 限制交给现有 ContextHelp。该组件处理 hover/focus/click、原生 popover、Escape 和局部状态,不执行委派或模型操作;测试未替换其生产判断。六条 synthetic 记录含已验收、等待读回、历史、未知、恢复和不可用,四个绑定含重复 Agent 的不同任务,所以原本复杂的下游验收仍有实际输入。
| 完整同源场景 | 结果 | 意义 |
|---|---|---|
| base旧测试,同产品字节 | exit1 /34.793s;第132行反复找到隐藏段落,30s超时 | 已独立复现真实误报 |
| 当前head | exit0 /12.324s;场景10.969s,acceptance PASS | 目标交互及完整原场景通过 |
| 当前测试,仅产品可见范围正文改错 | exit1 /35.139s;第138行完整语义断言失败 | aria/计数/记录/测试均不变,错误说明仍被拒绝 |
负例是一次私有源码变异后实际 rebuild 的产品,不是改测试返回值或制造启动故障。真实打包 HTTP/DOM/popover/focus 在本机执行;团队数据来自既有受控 API fixture,没有启动真实成员或模型。标准当前 head 本地 premerge 的四项直接检查及所有自动选择项通过,源码打包/校验通过;未查询、轮询或等待 CI。
对主干的风险
没有发现阻塞项。最容易被这类“修复测试”隐藏的方向是:表现断言删掉后,界面依然有标签却丢了范围、误选了目标或制造确定性。上述变异保持更简单的表面条件,执行不变的当前测试,仍在目标语义断言失败;完整正例同时覆盖后续旧路径,未把预期失败或准备错误当成产品通过。作者Windows结果属于作者报告,本轮证据是独立本机实际打包运行。开发服务器、安装态和在线模型不在本次已验范围。
覆盖检索结论:Bounded scan across existing browser scenarios found no other test asserting this exact six-record/current-coordinator/paging-not-team-snapshot contract with focus and no model turn. Shared ContextHelp cases cover mechanics, not that scope. Neighbor7323 tests selected accepted report versus incomplete team acceptance, a different evidence boundary.
完整42项开放队列及同作者批次已检查;#7316空运行说明、#7323已验报告与团队覆盖、#7324原生UTF-8 fixture、#7319运行时redaction及#7326测试worker编码分别有不同边界,背景扫描不授予它们通过或构成第三项评审。没有已证实的重复样板违规或警告后反复违规,不因若干小PR就推荐限制账号。保留本来有用的下游语义,潜在公共helper整合不需要现在创建平行任务。回退只涉及一个测试文件,无产品迁移或权限变化。
我的整体评价
这次维护交付有实际闭环:旧测试确有误报,当前全场景可执行,独立产品语义负例仍被拒绝。Thirteen inline lines stay in the existing scenario; no helper or framework introduced. Extracting a one-use flow now adds indirection without a demonstrated shared owner. 已查看现有打包截图的桌面/移动内容作为上下文,但不把未改的界面描述成新设计或更高可读性的证明。
本次只改 loopx-mode.mjs;生产 GoalTeamWork、ContextHelp、前端与打包资产在 base/head 字节一致,没有渲染呈现变更。 真实团队后端、实时 worker、模型执行和安装版 App 未在本测试修复中验收;当前活动数据来自受控 API fixtures。 用户完成原任务不增加陈述、复制、确认或准备轮次;测试走已有可选帮助/设置入口。无阻塞发现,最强缺失范围就是上述真实运行/安装边界,不由fixture通过推断。发布批准后会按原生closeout/readiness读回剩余评审门限;这不授予合并权限,也不撤销其他reviewer的有效阻塞。
English verdict: APPROVE at c181338c04627f22cc74f4c60a645f1414dc17e0. No blocking finding. The full native packaged loopx-mode scenario passes; immutable-base stale assertions fail on the same product, and an unchanged current test rejects a deliberate product-semantic mutation at the precise changed invariant. Accepted design, downstream coverage and existing overlap were reviewed; local premerge passes. CI was not consulted. Controlled team API fixtures do not qualify live Goals/models or the installed App. Approval grants no merge or dismissal authority.
Goal And Delivered Outcome
The packaged
loopx-modescenario waits for a delegation-scope paragraph to be visible inline. The shipped team view now shows the count and places the scope explanation behind the existing 委派记录范围 help control, so the scenario repeatedly finds a hidden paragraph and times out.Verify the real interaction: visible six-delegation count, opening the named help, reading the complete six-record/current-coordinator/pagination-not-team-snapshot qualification, Escape dismissal and retained focus. Reading help must not start a model turn. Existing binding reconciliation, authority, execution-classification and evidence assertions remain intact.
Basis: actual CI failure. Intended base:
main; no issue closeout claimed.Author Declaration
Written by: model_agent (OpenAI Codex), under the author's direction. Implemented against
goal-team-work.tsx,context-help.tsxand the explanations-on-demand design contract atf094b2cfb2acde7a4a0d4d875bba52f64ac31ba9.Validation
Tested revision:
c181338c04627f22cc74f4c60a645f1414dc17e0. Run state: finished. Inputs: synthetic. Native Windows / Node 24.20.0; own-source backend and verified same-revision packaged assets.loopx-modescenario passes, including all downstream binding, classification, permission and model-turn checks.Reproduce with a compatible test environment and Playwright configured:
Scope And Continuation
Only the existing durable browser scenario changes. No new helper, capability, protocol vocabulary or decision owner. The bounded future-facing pass reuses the existing accessible control; further abstraction is unnecessary. UI impact: none; frontend/Lark/CLI product interfaces unchanged. Shared-authority RFC fixture impact: N/A.
Current-head CI and maintainer review remain pending. No live Goal, model execution, global upgrade or self-merge. DCO signed; raw evidence remains private.