Skip to content

test(workspace): qualify the partial team coverage disclaimer - #7323

Merged
huangruiteng merged 2 commits into
mainfrom
codex/team-evidence-scope-acceptance-20261025
Oct 26, 2026
Merged

huangruiteng merged 2 commits into
mainfrom
codex/team-evidence-scope-acceptance-20261025

Conversation

@BigDataDZ

@BigDataDZ BigDataDZ commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Goal And Delivered Outcome

After the existing compact-navigation acceptance passes, the packaged team-evidence scenario times out looking for an inline partial-coverage warning. The shipped results view exposes that warning through 团队记录未完全核验 contextual help.

Open the existing help and verify the full disclaimer: some checked work is unverifiable, and the current report's acceptance does not represent the whole team. Verify Escape dismissal and focus return, unchanged selected report content, and no new model turn. Preserve all downstream artifact, adoption, pagination, stale-record erasure, safe rendering, feedback, pause and mobile assertions.

Basis: packaged browser failure, also reproduced by the corresponding dashboard job. Intended base: main; no issue closeout claimed.

Author Declaration

Written by: model_agent (OpenAI Codex), under the author's direction. Implemented against goal-team-results.tsx, context-help.tsx and the existing explanations-on-demand contract at 06f51b7e43adc546b16b6b2590d9bd2ea27bae31.

Validation

Tested integration revision: a45e22b. Run state: finished. Inputs: synthetic. Native Windows / Node 24.20.0, own-source disposable backend and freshly built/verified same-revision packaged assets.

  • Full untouched packaged scenario reproduces the exact hidden-warning failure.
  • Complete corrected team-evidence packaged scenario passes, including the existing evidence, authority, recovery and mobile checks.
  • Syntax, whitespace, bilingual RFC diff and public-boundary checks pass. Independent author-side review found no actionable blocker.
  • Development Vite and installed/live App behavior were not qualified. Product rendering and runtime behavior are unchanged.

Reproduce with a compatible test environment and Playwright configured:

python scripts/chat_bundle.py build
$env:LOOPX_PERSONAL_WORKSPACE_SCENARIO='team-evidence'
$env:LOOPX_PERSONAL_WORKSPACE_PACKAGED='1'
node examples/personal-workspace-browser-smoke.mjs

Scope And Continuation

One durable browser scenario owns this interaction acceptance. No new helper, vocabulary, capability or decision owner. The bounded future-facing pass reuses the existing accessible control; a separate abstraction is unnecessary. UI impact: none; no frontend/Lark/CLI product changes. Shared-authority RFC fixture impact: N/A.

Integrated main 2b72d30fca7f452a71dffb723ebf6d1e2e878484; complete freshly rebuilt packaged team-evidence passes on native Windows (17485ms). Existing navigation/delegation/activity repairs are inherited from main, not duplicated. The old e1b head has an APPROVED review; it is not approval of this new integration head. Current-head CI and maintainer re-review remain pending. No live Goal, model execution, global upgrade or self-merge. DCO signed; raw evidence remains private.

Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent | gpt-6.1-sol | OpenAI | runtime_reported | reasoning_effort=max

未发现阻塞问题。评审对象:e1b27856a276107cd96a05e641ba9ed6d23c23ff。

动机

维护团队成果页面的开发者,需要让打包回归真正读到“单份报告通过不代表整个团队通过”的完整说明。旧测试一直等待默认隐藏的说明正文,整个团队证据场景因此超时,后续验收无法执行;新版先打开已交付的按需帮助,再检查完整含义和关闭后的上下文。同源打包实际重放中,旧场景在隐藏正文处超时,新场景完整通过;把说明改为整个团队已验收、或让 Escape 后焦点丢失,两种独立产品缺陷都使新场景失败。本 PR 只修复和加强既有回归,不修改页面、后台权限或模型执行;不以合成场景宣称正常安装 App、真实团队采用或完整产品验收。

改动思路

最小修复是在原场景通过可访问的“团队记录未完全核验”入口打开帮助,按真实用户的读取顺序核完整免责声明,再验证 Escape、焦点、原报告和模型请求。无需让产品恢复默认说明段落,也不需要另一份 smoke、通用 helper 或新的状态 owner。这样既解除陈旧定位导致的假失败,又保留“不把一份报告当全队验收”的独立语义压力。

具体改动

依据 docs/development/design.md,规格版本 06f51b7e43adc546b16b6b2590d9bd2ea27bae31,核对 Explanations On Demand:既有 ContextHelp 提供完整按需解释,Escape 和焦点返回可用,阅读帮助不调用模型或改变工作。该规范原本就存在,未用测试补丁重写规格。

关键内容讲解

teamEvidenceScenario 用现有按钮的准确角色/名称定位,打开其所属 tooltip,核验完整 status 文本。随后检查提示隐藏、焦点仍在触发按钮、原 report.md 内容不变和请求数不增。它只替换一处旧等待,原有产物、采用、分页、来源失效擦除、安全渲染、反馈、暂停和窄屏断言保持不变。diff 是测试 +15/-1,生产代码为零;已逐文件确认 apps 和 loopx 生产树相同。

对主干的风险

独立使用同源新打包资产和现有真实浏览器测试框架重放:不可变旧基线在隐藏正文处等待 30000ms 后失败;当前完整 packaged team-evidence 通过,场景约 9.84 秒。额外将产品免责声明改为“当前报告代表整个团队的验收”,新断言在对应含义检查处失败;在 Escape 关闭后强制 blur,焦点返回断言也失败。两种 mutation 都只存在于隔离验证副本,未污染精确 head,也未弱化断言或放宽超时。

原生 premerge 的 4 direct、5 catalog 和 1 public-boundary 检查全过,DCO 已核对。没有查询、轮询或等待 CI。API 返回和成员状态仍是合成夹具,所以该结果证明已交付页面的测试路径及其敏感性,不证明真实团队验收、生产排序新鲜度或真实模型采用。现有 coverage 搜索和当前同作者相邻 PR 的不同边界不支持重复 smoke/批量同形提交判断。

我的整体评价

APPROVE,限定这个完整 head 的回归维护。长期调度/权限/持久 owner 无改变;产品使用体验保留,新测试保护原有完整解释、焦点和零模型副作用。复用既有场景是合适的有界简化,新的抽象或跟踪任务没有必要。已检查完整单文件 diff 及 base/head apps、loopx 生产源码:没有渲染改动,打包场景是既有界面的自动检查,无需为测试修正新增视觉设计结论或 PR 首屏截图。未验证范围:本轮运行于 macOS、Node24.21.0 和同源新构建资产,API 数据为合成夹具;作者的原生 Windows 记录仍为作者证据,正常安装 App、真实模型、团队采用和整页审美未作本次资格。这些限制不要求该测试修正完成父级 UI 或团队采用工程,也不授予合并或共享安装权限。

English verdict: APPROVE e1b2785. The existing packaged scenario now opens the shipped contextual help, preserves the full partial-acceptance warning, focus, selected report and zero-model behavior. Full scenario and native premerge passed; wrong-disclaimer and focus-loss product mutations fail the new assertions. Synthetic APIs and installed/live adoption remain separate boundaries.

Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
@huangruiteng
huangruiteng merged commit b952235 into main Oct 26, 2026
6 of 7 checks passed
@huangruiteng
huangruiteng deleted the codex/team-evidence-scope-acceptance-20261025 branch October 26, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants