Repository navigation
test(chat): initialize source ownership in the delegation fixture - #7526
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent; model=gpt-6.1-sol; provider=OpenAI; declaration_source=runtime_reported; reasoning_effort=max
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
APPROVE，精确 head aafad9b51877c9b2db908715eefe6765f3ac5d8f，本次独立验证未发现阻塞项。
动机 / Motivation
运行打包委派搜索回归的维护者，以及依赖该回归保护来源隔离的用户。 旧一次性 Chat 夹具没有安装会话来源 owner，读取原管家来源时连接关闭，测试尚未进入委派搜索就失败；修复后明确读到未选择来源，并可验证损坏来源拒绝与重试恢复。 独立 HTTP base/head 复现旧断连、新200/409/200及零POST；完整新打包搜索流程保留分页、原文返回、焦点、来源隔离和只读检查。 只修测试夹具和断言，不改生产权限、来源选择、UI、超时、评分、模型或发布资格。 该切片闭合夹具缺陷；正式安装、全发布矩阵和其它团队证据流程不由本 PR 证明，沿原对应工作继续。
改动思路 / Approach
夹具直接调用生产 install_conversation_transports，复用同一个来源绑定 owner；空 provider factories 和拒绝观察器使合成测试无法接触外部提供方。 当前 PR 仅恢复一条既有打包搜索回归并新增来源损坏/恢复反例；没有新产品功能、抽象、状态 authority 或独立调度。 对原已授权任务没有新增配置、复制资料、重输意图或确认回合；发生失败仍沿原恢复owner处理。搜索 base/head 的 install_conversation_transports、conversation_bindings、app_steward_target、steward_requests_fixture、delegation-search、Retry history；现有production initializer与62测试保护owner，浏览器增加的是跨HTTP/打包页面的集成拒绝/恢复。相邻7527修另一团队证据help，不重复此来源问题。
具体改动 / Changes
没有独立的已接受夹具规范；依据已复现HTTP缺陷和现有生产初始化/来源拒绝边界判断。另对照 docs/development/good-smokes.md，未把新增断言当作自己的规范。
关键代码讲解
- main：组合一次性真实Chat/SQLite/Inbox夹具。创建server后通过既有生产入口安装会话绑定，代替缺失初始化。外部provider必须不可达；来源异常不回退。
- install_conversation_transports：未改动的生产组合owner。本PR复用其无外部factory分支，不复制来源判断。binding.owner保持唯一，fixture只供应IO依赖。
- source：浏览器前先核真实来源端点。明确200且null selection，避免启动后遇隐藏断连才误判产品。不把空来源等同失败或允许外部源。
- source-unavailable/source-recover walkthrough：验证损坏来源拒绝和用户显式重试。临时binding损坏后409并隐藏委派；恢复后走原Retry history。拒绝先于历史显示；重试后保留原搜索入口。
PASS：同head真实打包搜索旅程6.738秒完成，保留分页前搜索、计数、原对话、清空/更多记录、库存失败重试、已回传历史、迟到响应、Escape/焦点、工作区隔离、390px、英文及只读断言。62项binding/transport Python测试通过；同源build:chat通过，既有500kB chunk告警保留。标准预检5项direct、5项selected通过，零manual hold。
独立相同HTTP探针在不可变base复现断连/缺binding；head返回200空选择、损坏后409、恢复后200，最终POST为0且原来源记录不变。首次评审测试路径和探针字符串设置错误未执行产品，更正后的同源实际结果替代这些设置失败，原记录保留。
对主干的风险 / Risks
主要风险是为消除红测而跳过来源guard或提供假的成功后置条件。本补丁反而调用原生产装配，保留拒绝外部provider的观察器，并在真实HTTP和打包页面检验损坏来源409、隐藏委派以及原Retry history恢复。未增加timeout、sleep、mock来源成功或更改产品断言。两个现有集成文件的增量保护unit测试无法发现的server装配缺失；相邻7527是不同help/领取测试问题，不是同形重复smoke。
该改动只有fixture本地命令，没有新增共享语义词汇、来源authority、持久兼容分支或产品开关。真实SQLite/Chat/Inbox覆盖足够支撑本次装配修复；没有修改存储实现，故不冒称PostgreSQL或全发布资格。
语义与 CI 对齐
本地检查针对上述精确head；按当前wait_for_ci=false政策未查询、轮询或等待CI。通过的风险预检不是merge权限，也不修改历史失败或父级验收。回退限定为撤销当前切片，原捕获、来源和业务状态保留。
我的整体评价 / Verdict
这是可独立验证和回退的 justified_increment。夹具直接调用生产 install_conversation_transports，复用同一个来源绑定 owner；空 provider factories 和拒绝观察器使合成测试无法接触外部提供方。 当前 PR 仅恢复一条既有打包搜索回归并新增来源损坏/恢复反例；没有新产品功能、抽象、状态 authority 或独立调度。 long_horizon 与 user_experience 均为 preserved：原完整来源、后续工作和恢复仍可达，未新增人机回合；不将传输字节或测试通过升级为净收益。已检查完整两个测试文件和未变的产品界面；没有渲染实现变化，visual_review 不适用。 未验证范围：打包合成旅程不证明正式App、真实外部provider或用户理解；未执行完整发布资格。 该切片闭合夹具缺陷；正式安装、全发布矩阵和其它团队证据流程不由本 PR 证明，沿原对应工作继续。
English verdict: APPROVE aafad9b51877c9b2db908715eefe6765f3ac5d8f. The real fixture owner restores packaged delegation-search coverage while preserving source refusal, retry and read-only boundaries; integrated release qualification remains separate.
The delegation-search smoke fabricated a 200 answer for /api/chat/app-steward with page.route, so the page never observed the fixture's later source refusal and the "steward conversation is unavailable" alert could not appear. The expectation added with loopx-project#7526 therefore failed on every run, including runs of unrelated branches. The fixture already installs the real conversation source owner and answers {ok: true, binding_id: null, session_id: null} in its normal state, exactly the payload the route fabricated. Dropping the route lets the page read the real answer, so the refusal and the recovery after it are exercised against the server instead of a stub. Validation: the packaged smoke reproduces the same timeout before the change and passes afterwards; RFC bilingual check passed; loopx canary premerge --from-git-diff green; public boundary scan clean. Signed-off-by: xiaoan17 <anbc1224@gmail.com>
Goal And Delivered Outcome
The packaged delegation-search smoke stops before it can open delegations: its disposable Chat server never installs the conversation binding store used by
/api/chat/app-steward. The real handler closes the connection, and the frontend correctly refuses an unverified source.Initialize the fixture through the production
install_conversation_transportsentrypoint. Keep external providers unavailable, assert the real unselected-source response, and cover corrupt-source refusal followed by recovery through the existing Retry history action. Related failure: PR #7515 browser job. Intended base:main.Author Declaration
78bd4ff8c5c41a963b2331ee05b813c843b4ea03.examples/personal-workspace-browser/steward_requests_fixture.pyapps/presentation/dashboard/smoke/delegation-search-browser-smoke.mjsSelf-check: read the fixture, production initializer/handler, and existing browser assertions. Reuse the existing composition owner; no source guard, assertion or timeout was relaxed.
Scope And Continuation
Complete within this fixture-repair scope. Two durable test files change; production behavior, configuration and UI are unchanged. This is independently reviewable and reversible. It repairs one shared CI prerequisite; it does not qualify the separate team-evidence browser failure, the controller refactors, live App adoption or a merge.
Validation
aafad9b51877c9b2db908715eefe6765f3ac5d8f(focused runs used identical working-tree bytes before the commit).regression_parity78bd4ff8fails with a closed socket; the repaired fixture passes. Same bundle and environment.real_entrypoint/real_backendnode apps/presentation/dashboard/smoke/delegation-search-browser-smoke.mjs: full packaged flow, 24.784s. Retains search before pagination, counts, original conversation, clear/paging, inventory failure/retry, returned history, stale response, Escape/focus, workspace isolation, narrow layout, English and read-only checks; adds source refusal/recovery.integrationuv run --extra test python -m pytest -q tests/test_chat_conversation_bindings.py::test_app_steward_corrupt_legacy_configuration_never_falls_back: 1 passed; unselected source and malformed configuration do not fall back to a provider.staticnpm run build:chat; changed Python Ruff, MJS syntax, diff checks and semantic advisory. No new supported shared-vocabulary carrier detected.staticuv run --extra test loopx canary premerge --from-git-diff --git-diff-base origin/main: 5 direct + 5 selected checks passed, no manual holds; exact-scope quality receipt valid.integrationintegrationThe first added negative-case run used the wrong English retry label; it was corrected to the existing exact Retry history control and the full scenario reran successfully. No production storage implementation changes, so a PostgreSQL authority matrix is outside this test-only repair.
Frontend / Visual Evidence
UI impact: none. Before/after screenshots and a preview are N/A: only fixture initialization and browser assertions change. The existing packaged UI is exercised with synthetic data on desktop and 390px; this PR makes no new visual-quality or installed-App claim.
Type Of Change / Area
Test update and CI fixture bug fix; host/runtime integration coverage. Bounded refactoring applied: use the existing transport initializer instead of duplicating binding initialization. No new capability or abstraction.
Shared-authority RFC fixture impact
N/A: no production authority, protocol, migration, provider routing or compatibility changes; no RFC pair changed.
Boundary Checklist