Skip to content

[crypto] Manual backport 29644#29650

Merged
nasahlpa merged 1 commit intolowRISC:earlgrey_1.0.0from
andrea-caforio:backport-29644-to-earlgrey_1.0.0
Apr 7, 2026
Merged

[crypto] Manual backport 29644#29650
nasahlpa merged 1 commit intolowRISC:earlgrey_1.0.0from
andrea-caforio:backport-29644-to-earlgrey_1.0.0

Conversation

@andrea-caforio
Copy link
Copy Markdown
Contributor

(cherry picked from commit d5f707b)

@andrea-caforio andrea-caforio requested a review from a team as a code owner April 1, 2026 10:59
@andrea-caforio andrea-caforio requested review from timothytrippel and removed request for a team April 1, 2026 10:59
@andrea-caforio andrea-caforio added the CI:Rerun Rerun failed CI jobs label Apr 1, 2026
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Apr 1, 2026
@andrea-caforio
Copy link
Copy Markdown
Contributor Author

Faling USB test is unrelated.

Copy link
Copy Markdown
Contributor

@siemen11 siemen11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Andrea!

@vogelpi vogelpi self-requested a review April 1, 2026 21:10
Copy link
Copy Markdown
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but the commit referenced in the commit message is wrong (it points to a commit message in your fork). Can you please correct that and let it point to the commit on master 93d8e06 @andrea-caforio ?

Signed-off-by: Andrea Caforio <andrea.caforio@lowrisc.org>
(cherry picked from commit 93d8e06)
@andrea-caforio andrea-caforio force-pushed the backport-29644-to-earlgrey_1.0.0 branch from b4514eb to de457a1 Compare April 2, 2026 06:01
@andrea-caforio
Copy link
Copy Markdown
Contributor Author

Sorry about that, it's fixed now. I was following the lowrisc-ci bot instructions.

#29644 (comment)

@andrea-caforio andrea-caforio added the CI:Rerun Rerun failed CI jobs label Apr 7, 2026
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Apr 7, 2026
@andrea-caforio
Copy link
Copy Markdown
Contributor Author

Failing USB test is unrelated.

@nasahlpa nasahlpa merged commit a4cf4f3 into lowRISC:earlgrey_1.0.0 Apr 7, 2026
66 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants