Fix timing issue with heartbeat and improve connection error logic#11
Open
ashleyghooper wants to merge 2 commits into
Open
Fix timing issue with heartbeat and improve connection error logic#11ashleyghooper wants to merge 2 commits into
ashleyghooper wants to merge 2 commits into
Conversation
- The variables ERR_NOTIFY_INTERVAL and HEARTBEAT_MIN_INTERVAL used seconds values, but they are being compared with values returned from vim.uv.now() which returns milliseconds - Renamed the variables to clarify the time unit and multiplied the values by 1000 to give milliseconds durations Signed-off-by: Ashley Hooper <ashleyghooper@gmail.com>
- Add -X before POST so that POST is correctly received as the request type, not the first of several URLs for curl to request - Add -f so that curl detects all failures such as when a request goes via a proxy server (otherwise, any proxied requests are always treated as successful) - Add -s since we are not using the curl output - Since self.last_error_notify is initialised as nil, modify the error notification logic accordingly Signed-off-by: Ashley Hooper <ashleyghooper@gmail.com>
ashleyghooper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.