DM-54951 : Modularize ap_daytime script for CM-Service#277
Draft
tcjennings wants to merge 2 commits into
Draft
Conversation
tcjennings
force-pushed
the
tickets/DM-54951
branch
from
2652eff to
f6a0d6d
Compare
- separate dynamic env var definitions for external tool use - simplify APDB file naming - reduce dependence on 3rd party tool
tcjennings
force-pushed
the
tickets/DM-54951
branch
from
f6a0d6d to
a17d61d
Compare
- add annotated YAML document for cmservice definition of ap_daytime campaign
tcjennings
force-pushed
the
tickets/DM-54951
branch
from
37db766 to
ed5bc27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves modularity of ap_daytime submit script
The primary driver for this specific change is for external tooling (e.g., CM Service) to obtain dynamic configuration for this process without involving the manual submit script. In this case, the lists of
BAD_DETECTORSandBLOCKSare moved to a separate script which the submit script cansource. Likewise, CM Service can fetch this file using aResourcePathreferring to the raw github url of the file to use in launcher script.Incidental changes involve a simpler and more idiomatic resolution of a date-based APDB config file name and the disuse of any third-party tools for fetching the same.