SP-3027: fix NB 105 6 custom coadds

[shenmingfu]

No description provided.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[athornton]

This is fine. You might want to make sure that you don't do any of this if the os.getenv() comes back None, but at least in that case making the path will fail with an error and you won't do anything weird with the unlink call.

I'll again reiterate for the record that SCRATCH_DIR is only going to be set at IDF RSP instances, and specifically that it will not work at USDF.

No opinion on the mtv->image change, but I presume it does what you mean it to.

[athornton]

The removal happens at "32 05 * * 0" # Sunday morning, 12:32 AM (UTC-5) for data.lsst.cloud. So late Saturday on the West Coast, early Sunday East Coast, 5:32 in UTC. 12:27 AM for int, 12:19 for dev.

[shenmingfu]

@athornton Thank you for your comments and review!

You might want to make sure that you don't do any of this if the os.getenv() comes back None

I guess you mean $SCRATCH_DIR does not exist and then os.getenv("SCRATCH_DIR") gives None. In that case Path() will return an error. Does that mean on RSP during the cleaning time even the variable $SCRATCH_DIR gets removed? I just added an if case there to check if it's None. In the description above the cell I mentioned do not run this step during the cleaning time.

I'll again reiterate for the record that SCRATCH_DIR is only going to be set at IDF RSP instances, and specifically that it will not work at USDF.

Yes, we mentioned that this is for RSP (in the description and at the beginning of the notebook).

No opinion on the mtv->image change, but I presume it does what you mean it to.

Yeah mtv is an old command, and we updated it to image.

So late Saturday on the West Coast, early Sunday East Coast, 5:32 in UTC

Thanks. I changed the text to "around noon Sunday Pacific time".

[athornton]

If SCRATCH_DIR wasn't set then scratch_path will not be defined.

[shenmingfu]

Yes, that will throw an error. But I mentioned in the description text that the user should not run this step (and following steps) during / right before the cleaning time. And the undefined scratch_path also prevents the user from running further steps (especially writing large files to local space). So I think that's fine.
Please let me know if you have any other comments.