Repository navigation
fix: connect Google from settings without a 404 - #137
Merged
Merged
Conversation
The Connect button used /auth/google/login, which is the sign-in start. A signed-in user hitting that URL either bounced off guest middleware or landed on a 404. Settings now has its own connect route, and the OAuth callback links the account when you are already signed in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/settings/authenticationpointed at/auth/google/login, the guest sign-in start. A signed-in user landing there got a 404 (or bounced offguest).GET /settings/authentication/providers/{provider}/connect, login stays on/auth/{provider}/login, and the callback links the account when you are already signed in.Test plan
/auth/google/login./loginstill works.