π‘οΈ Sentinel: [HIGH] Fix missing user role in auth#39
π‘οΈ Sentinel: [HIGH] Fix missing user role in auth#39Magnopiro-oficial wants to merge 1 commit into
Conversation
Co-authored-by: Magnopiro-oficial <122941268+Magnopiro-oficial@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Broken Access Control. The
Usermodel lacked arolefield, and the JWT payload did not include it, causing all admin authorization checks (e.g.,user.role === 'ADMIN') to fail universally.π― Impact: Denial of Service for Admins. No user could perform administrative actions.
π§ Fix:
role UserRole @default(USER)tobackend/prisma/schema.prisma.AuthServiceto includerolein the JWT payload and login response.β Verification:
schema.prismacontainsrolefield.auth.service.tsusesUserRoleenum anduser.role.npm run buildinbackend/to confirm type safety.PR created automatically by Jules for task 10018601640562131738 started by @Magnopiro-oficial