Fix setSelectIndex method name typo in Dropdownlist#62
Open
donghwan-yu wants to merge 3 commits into
Open
Conversation
The selectIndex prop setter called comp.setselectIndex (lower-case 's'), which does not match the native binding setSelectIndex.
The previous setItems() appended "\n" after every item, which left a trailing newline at the end of the options string.
There was a problem hiding this comment.
3 issues found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="doc/component/Tabs.md">
<violation number="1" location="doc/component/Tabs.md:22">
P3: Typo: 'controll' should be 'control'</violation>
</file>
<file name="doc/component/GIF.md">
<violation number="1" location="doc/component/GIF.md:23">
P3: Import path `lvlgjs-ui` should be `lvgljs-ui` to match the declared package dependency in package.json. The transposition won't resolve at runtime since npm module resolution is exact. This is a pre-existing pattern in other docs; consider fixing them all while adding this new file.</violation>
</file>
<file name="doc/component/Arc.md">
<violation number="1" location="doc/component/Arc.md:42">
P3: The Arc usage example points readers at a misspelled package name, so copying it will fail module resolution. The repository dependency is `lvgljs-ui`, while this line uses `lvlgjs-ui`; updating the import keeps the new docs runnable.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
|
|
||
| ## Usage | ||
| ```jsx | ||
| import { Arc } from 'lvlgjs-ui' |
There was a problem hiding this comment.
P3: The Arc usage example points readers at a misspelled package name, so copying it will fail module resolution. The repository dependency is lvgljs-ui, while this line uses lvlgjs-ui; updating the import keeps the new docs runnable.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At doc/component/Arc.md, line 42:
<comment>The Arc usage example points readers at a misspelled package name, so copying it will fail module resolution. The repository dependency is `lvgljs-ui`, while this line uses `lvlgjs-ui`; updating the import keeps the new docs runnable.</comment>
<file context>
@@ -0,0 +1,80 @@
+
+## Usage
+```jsx
+import { Arc } from 'lvlgjs-ui'
+import { useState } from 'react'
+
</file context>
Missing documents has been included.
Author
|
@derekstavis Could you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selectIndex prop setter called comp.setselectIndex (lower-case 's'), which does not match the native binding setSelectIndex.
Summary by cubic
Fix Dropdownlist selectIndex handling and options rendering: call comp.setSelectIndex correctly and avoid a trailing newline in native setItems, so selection updates reach the native binding and no blank option appears.
Adds docs for Arc, GIF, and Tabs, and links them in the readme.
Written for commit bc9ad5f. Summary will update on new commits.