feat: publish internal packages as public on npm#15
Merged
Conversation
- Remove @lytics registry override to allow public packages to publish to npm - Only set authentication token, let publishConfig determine registry - Add packages: write permission for GitHub Packages publishing
…chema - Remove default collection names from FirestoreAdapter - Require users to configure their own collection names - This prevents exposing internal Firestore schema structure
- Use sample collection names in tests instead of internal names - Remove duplicate collections key in test - All tests passing with required collections
- Remove specific internal collection names from examples - Add note that users must configure their own schema - Update installation instructions for npm (no GitHub Packages) - Clarify that package is Contentstack-specific but generic
- Update @lytics/playwright-adapters-internal to publish to npm - Update @lytics/playwright-journey to publish to npm - Remove GitHub Packages registry configuration - Packages will be public but require users to configure their own schema
- Remove GitHub Packages auth steps (no longer needed) - Remove packages:write permission - Simplify workflow comments - All packages now publish to npm via OIDC
- Replace this.db! with explicit null checks - Improves type safety and satisfies Biome linting rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables publishing internal packages ( and ) as public packages on npm while hiding internal schema details.
Changes
🔒 Hide Internal Schema
📦 Publishing Changes
📝 Documentation
🧪 Testing
Impact
Version Bumps