Skip to content

Fix exists operator to return true for empty strings and zero times #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junichif merged 2 commits into from
Mar 20, 2026
Merged

Fix exists operator to return true for empty strings and zero times #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26b5b6d
Fix exists operator to return true for empty strings and zero times
junichif Mar 19, 2026
1bc01bc
Update go.mod to go 1.26 and align dependency versions with lio
junichif Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions expr/builtins/builtins_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,14 @@ var builtinTests = []testBuiltins{
{`exists(toint(price))`, value.BoolValueTrue},
{`exists(-1)`, value.BoolValueTrue},
{`exists(non_field)`, value.BoolValueFalse},
{`exists("")`, value.BoolValueFalse},
{`exists("")`, value.BoolValueTrue},
{`exists(true)`, value.BoolValueTrue},
{`exists(1.5/6.7)`, value.BoolValueTrue},
{`exists(tonumber(10/0))`, value.BoolValueFalse},
{`exists(0)`, value.BoolValueTrue},
{`exists(Address)`, value.BoolValueTrue},
{`exists(emails)`, value.BoolValueTrue},
{`exists(ZeroTime)`, value.BoolValueFalse}, // ZeroTime
{`exists(ZeroTime)`, value.BoolValueTrue}, // ZeroTime
{`exists(Created)`, value.BoolValueTrue},
{`exists(Updated)`, value.BoolValueTrue},

Expand Down
10 changes: 2 additions & 8 deletions expr/builtins/logic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func lessThanEval(ctx expr.EvalContext, vals []value.Value) (value.Value, bool)
//
// exists(real_field) => true
// exists("value") => true
// exists("") => false
// exists("") => true
// exists(empty_field) => false
// exists(2) => true
// exists(todate(date_field)) => true
Expand All @@ -194,7 +194,7 @@ func (m *Exists) Validate(n *expr.FuncNode) (expr.EvaluatorFunc, error) {

func existsEval(ctx expr.EvalContext, args []value.Value) (value.Value, bool) {

switch node := args[0].(type) {
switch args[0].(type) {
// case *expr.IdentityNode:
// _, ok := ctx.Get(node.Text)
// if ok {
Expand All @@ -208,9 +208,6 @@ func existsEval(ctx expr.EvalContext, args []value.Value) (value.Value, bool) {
// }
// return value.BoolValueFalse, true
case value.StringValue:
if node.Nil() {
return value.BoolValueFalse, true
}
return value.BoolValueTrue, true
case value.BoolValue:
return value.BoolValueTrue, true
Expand All @@ -219,9 +216,6 @@ func existsEval(ctx expr.EvalContext, args []value.Value) (value.Value, bool) {
case value.IntValue:
return value.BoolValueTrue, true
case value.TimeValue:
if node.Nil() {
return value.BoolValueFalse, true
}
return value.BoolValueTrue, true
case value.StringsValue, value.SliceValue, value.MapIntValue:
return value.BoolValueTrue, true
Expand Down
138 changes: 75 additions & 63 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,97 +1,109 @@
module github.com/lytics/qlbridge

go 1.23.0

toolchain go1.24.1
go 1.26

require (
github.com/araddon/dateparse v0.0.0-20190622164848-0fb0a474d195
github.com/araddon/gou v0.0.0-20211019181548-e7d08105776c
github.com/blevesearch/bleve/v2 v2.4.4-0.20250311051258-dd102de3e3fd
github.com/dchest/siphash v1.2.1
github.com/go-sql-driver/mysql v1.4.1
github.com/google/btree v1.0.0
github.com/araddon/dateparse v0.0.0-20210429162001-6b43995a97de
github.com/araddon/gou v1.2.0
github.com/blevesearch/bleve/v2 v2.5.2
github.com/dchest/siphash v1.2.3
github.com/go-sql-driver/mysql v1.9.3
github.com/google/btree v1.1.3
github.com/hashicorp/go-memdb v1.0.4
github.com/jmespath/go-jmespath v0.4.0
github.com/jmoiron/sqlx v1.2.0
github.com/jmoiron/sqlx v1.4.0
github.com/leekchan/timeutil v0.0.0-20150802142658-28917288c48d
github.com/lytics/cloudstorage v0.2.16
github.com/lytics/cloudstorage v0.2.17-0.20250708155716-c267217b862c
github.com/lytics/datemath v0.0.0-20180727225141-3ada1c10b5de
github.com/mattn/go-sqlite3 v1.9.0
github.com/mattn/go-sqlite3 v1.14.22
github.com/mb0/glob v0.0.0-20160210091149-1eb79d2de6c4
github.com/mssola/user_agent v0.5.0
github.com/mssola/user_agent v0.6.0
github.com/pborman/uuid v1.2.1
github.com/stretchr/testify v1.10.0
golang.org/x/net v0.37.0
google.golang.org/api v0.226.0
google.golang.org/protobuf v1.36.5
github.com/stretchr/testify v1.11.1
golang.org/x/net v0.52.0
google.golang.org/api v0.272.0
google.golang.org/protobuf v1.36.11
)

require (
cloud.google.com/go v0.112.2 // indirect
cloud.google.com/go/auth v0.15.0 // indirect
cloud.google.com/go/auth/oauth2adapt v0.2.7 // indirect
cloud.google.com/go/compute/metadata v0.6.0 // indirect
cloud.google.com/go/iam v1.1.6 // indirect
cloud.google.com/go/storage v1.39.1 // indirect
cel.dev/expr v0.25.1 // indirect
cloud.google.com/go v0.121.6 // indirect
cloud.google.com/go/auth v0.18.2 // indirect
cloud.google.com/go/auth/oauth2adapt v0.2.8 // indirect
cloud.google.com/go/compute/metadata v0.9.0 // indirect
cloud.google.com/go/iam v1.5.3 // indirect
cloud.google.com/go/monitoring v1.24.3 // indirect
cloud.google.com/go/storage v1.56.0 // indirect
filippo.io/edwards25519 v1.1.0 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.30.0 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.53.0 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.53.0 // indirect
github.com/RoaringBitmap/roaring/v2 v2.4.5 // indirect
github.com/bits-and-blooms/bitset v1.12.0 // indirect
github.com/blevesearch/bleve_index_api v1.2.3 // indirect
github.com/blevesearch/geo v0.1.20 // indirect
github.com/blevesearch/go-faiss v1.0.24 // indirect
github.com/bits-and-blooms/bitset v1.22.0 // indirect
github.com/blevesearch/bleve_index_api v1.2.8 // indirect
github.com/blevesearch/geo v0.2.3 // indirect
github.com/blevesearch/go-faiss v1.0.25 // indirect
github.com/blevesearch/go-porterstemmer v1.0.3 // indirect
github.com/blevesearch/gtreap v0.1.1 // indirect
github.com/blevesearch/mmap-go v1.0.4 // indirect
github.com/blevesearch/scorch_segment_api/v2 v2.3.5 // indirect
github.com/blevesearch/scorch_segment_api/v2 v2.3.10 // indirect
github.com/blevesearch/segment v0.9.1 // indirect
github.com/blevesearch/snowballstem v0.9.0 // indirect
github.com/blevesearch/upsidedown_store_api v1.0.2 // indirect
github.com/blevesearch/vellum v1.1.0 // indirect
github.com/blevesearch/zapx/v11 v11.4.1 // indirect
github.com/blevesearch/zapx/v12 v12.4.1 // indirect
github.com/blevesearch/zapx/v13 v13.4.1 // indirect
github.com/blevesearch/zapx/v14 v14.4.1 // indirect
github.com/blevesearch/zapx/v15 v15.4.1 // indirect
github.com/blevesearch/zapx/v16 v16.2.2-0.20250305220028-89edb0ef9aa9 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/blevesearch/zapx/v11 v11.4.2 // indirect
github.com/blevesearch/zapx/v12 v12.4.2 // indirect
github.com/blevesearch/zapx/v13 v13.4.2 // indirect
github.com/blevesearch/zapx/v14 v14.4.2 // indirect
github.com/blevesearch/zapx/v15 v15.4.2 // indirect
github.com/blevesearch/zapx/v16 v16.2.4 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/cncf/xds/go v0.0.0-20251210132809-ee656c7534f5 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/envoyproxy/go-control-plane/envoy v1.36.0 // indirect
github.com/envoyproxy/protoc-gen-validate v1.3.0 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/go-logr/logr v1.4.2 // indirect
github.com/go-jose/go-jose/v4 v4.1.3 // indirect
github.com/go-logr/logr v1.4.3 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/golang/geo v0.0.0-20210211234256-740aa86cb551 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/golang/snappy v0.0.4 // indirect
github.com/google/s2a-go v0.1.9 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.5 // indirect
github.com/googleapis/gax-go/v2 v2.14.1 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.14 // indirect
github.com/googleapis/gax-go/v2 v2.18.0 // indirect
github.com/hashicorp/go-immutable-radix v1.1.0 // indirect
github.com/hashicorp/golang-lru v0.5.1 // indirect
github.com/json-iterator/go v0.0.0-20171115153421-f7279a603ede // indirect
github.com/mschoch/smat v0.2.0 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
go.etcd.io/bbolt v1.3.7 // indirect
go.opencensus.io v0.24.0 // indirect
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.59.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.59.0 // indirect
go.opentelemetry.io/otel v1.34.0 // indirect
go.opentelemetry.io/otel/metric v1.34.0 // indirect
go.opentelemetry.io/otel/trace v1.34.0 // indirect
golang.org/x/crypto v0.36.0 // indirect
golang.org/x/oauth2 v0.28.0 // indirect
golang.org/x/sync v0.12.0 // indirect
golang.org/x/sys v0.31.0 // indirect
golang.org/x/text v0.23.0 // indirect
golang.org/x/time v0.11.0 // indirect
google.golang.org/appengine v1.6.8 // indirect
google.golang.org/genproto v0.0.0-20240213162025-012b6fc9bca9 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20250218202821-56aae31c358a // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250303144028-a0af3efb3deb // indirect
google.golang.org/grpc v1.72.2 // indirect
github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
github.com/spiffe/go-spiffe/v2 v2.6.0 // indirect
go.etcd.io/bbolt v1.4.0 // indirect
go.mongodb.org/mongo-driver v1.7.2 // indirect
go.opentelemetry.io/auto/sdk v1.2.1 // indirect
go.opentelemetry.io/contrib/detectors/gcp v1.39.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.61.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.61.0 // indirect
go.opentelemetry.io/otel v1.39.0 // indirect
go.opentelemetry.io/otel/metric v1.39.0 // indirect
go.opentelemetry.io/otel/sdk v1.39.0 // indirect
go.opentelemetry.io/otel/sdk/metric v1.39.0 // indirect
go.opentelemetry.io/otel/trace v1.39.0 // indirect
golang.org/x/crypto v0.49.0 // indirect
golang.org/x/oauth2 v0.36.0 // indirect
golang.org/x/sync v0.20.0 // indirect
golang.org/x/sys v0.42.0 // indirect
golang.org/x/text v0.35.0 // indirect
golang.org/x/time v0.15.0 // indirect
google.golang.org/genproto v0.0.0-20260217215200-42d3e9bedb6d // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20260217215200-42d3e9bedb6d // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20260311181403-84a4fc48630c // indirect
google.golang.org/grpc v1.79.2 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)

replace github.com/araddon/dateparse v0.0.0-20190622164848-0fb0a474d195 => github.com/lytics/dateparse v0.0.0-20241205004559-6cedc927c67b

replace github.com/araddon/gou v0.0.0-20190110011759-c797efecbb61 => github.com/lytics/gou v0.0.0-20220111003232-c7293e7b8946
replace (
github.com/araddon/dateparse => github.com/lytics/dateparse v0.0.0-20241205004559-6cedc927c67b
github.com/araddon/gou => github.com/lytics/gou v1.1.0
)
Loading
Loading