Add support for images in media search#254
Open
ltctceplrm wants to merge 37 commits into
Open
Conversation
- Auto fetches images with a small delay for rate limits - If the link to the image fails to load then it uses a placeholder emoticon - Also fixed the bug where steamapi doesn't show the year during the selection screen (only afterwards)
Closed
- Removed the css from styles.css, MediaDbSearchResultModal and MediaDbSeasonSelectModal - Created "MediaItemComponent" to replace the hardcoded css in a centralized manner
Also increased MAL API delay from 400ms to 750ms to avoid rate limits
* remove hacky double underscore
* added doc comments annotating functions
* removed unneeded comments
* use .createDiv( instead of createEl('div',
Contributor
Author
|
Okay I've done the fixes, the image icon does look a lot better than the emoji I used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI:
To complete FR #248
Used the wrong branch so I had to cherry pick the commits to the origin branch