Checks and fixes for pasting copied reference fields#103
Conversation
…ing compatibility.
|
Added support for pasting null values to the checks. When null is copied paste menu item will display warning that it will be set to null. If pasting null should be disallowed this is an easy change to revert. On a separate note, it seems that most PRs recently are failing checks, the runner says the UNITY_LICENSE or UNITY_SERIAL secrets are unavailable. This is a safety restriction with GitHub and actions running on pull request, they can't access the secrets of either the source or target repository to prevent malicious PRs from potentially leaking that data (for example printing it to the test logs), but this does throw a wrench in game-ci's builder and test runner. PRs seemed to be working before so not sure what changed, as it stands right now the tests can't be ran reliably. If I were to recommend an approach, instead of triggering the build and test checks |
|
New pasting behaviour differed from previous logic and intent where users could paste values between types, so moved most paste options into submenus so both "Paste Type and Values" and "Paste Values Only" can be provided.
|
Description
When copying and pasting values from a property's context menu, there were currently no checks in place to avoid certain issues:
JsonUtility.FromJsonOverwriteAdded logic to check for potential conflicts and handle them.
Changes made
SessionStatefor use in type safety comparisonsTypeCandiateService[which is mis-spelled as a note, should be Candidate]) then disable the menu item with message explaining incompatible type.TypeCandiateService, which evaluates theintrinsicTypePolicyandtypeCompatibilityPolicy, for use in testing field combability in pasting, so that theTypeCandiateServiceis a single point of truth on this test.