Fix visitListItem not being called by MarkupVisitor protocol dispatch#4
Open
SkylerSea wants to merge 1 commit intomadebywindmill:mainfrom
Open
Fix visitListItem not being called by MarkupVisitor protocol dispatch#4SkylerSea wants to merge 1 commit intomadebywindmill:mainfrom
SkylerSea wants to merge 1 commit intomadebywindmill:mainfrom
Conversation
The existing `visitListItem(_:orderedIndex:)` method has a second defaulted parameter, which means it does not satisfy the `MarkupVisitor` protocol requirement `visitListItem(_:)`. Swift resolves the protocol dispatch to the default extension implementation (which calls `defaultVisit`) instead of this type's method, so list item prefixes (bullets, numbers) are never inserted and newlines between items are lost. Add a one-parameter overload that matches the protocol signature and delegates to the two-parameter version. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visitListItem(_:orderedIndex:)has a second defaulted parameter which prevents it from satisfying theMarkupVisitorprotocol requirementvisitListItem(_:). Swift resolves protocol dispatch (markup.accept(&self)) to the default extension implementation (which callsdefaultVisit), so list item prefixes (bullets/numbers) are never inserted and newlines between items are lost.Repro
After fix
All existing tests pass (they were previously crashing/failing on list-related assertions).
🤖 Generated with Claude Code