Upgrade to htaccess-api-client v3 and modernise tooling#64
Merged
Conversation
- htaccess-api-client ^2.3 → ^3.0 - php ^8.0 → ^8.4 (required by v3) - symfony/console and symfony/yaml: drop pre-7 constraints - phpunit/phpunit ^9.5 → ^13.0 - phpstan/phpstan ^1.0 → ^2.0
v3 of htaccess-api-client moved all classes from Madewithlove\ to Madewithlove\HtaccessApiClient\. Add explicit imports in HtaccessCommand and TableRenderer.
- Replace @test docblock annotations with #[Test] attributes (removed in PHPUnit 11) - Replace deprecated <filter><whitelist> with <source><include> in phpunit.xml.dist - Add HtaccessClient import from new namespace in both test classes
Drop 8.0/8.1 matrix entries and the --ignore-platform-req workaround that was needed for them. Add explicit PHP setup to the run job.
Fixes PHPStan errors: untyped static property and mixed passed to parent::__construct(). The attribute is the idiomatic Symfony approach since Console 5.3.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=========================================
Coverage 97.01% 97.01%
Complexity 38 38
=========================================
Files 2 2
Lines 134 134
=========================================
Hits 130 130
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Madewithlove\HtaccessApiClientnamespace and requires PHP 8.4^7.0 || ^8.0Commits
Structured for commit-by-commit review:
useimports inHtaccessCommandandTableRenderertoMadewithlove\HtaccessApiClient\*@testannotations with#[Test]attributes; updatephpunit.xml.distcoverage configTest plan
./vendor/bin/phpunitpasses (16 tests, 26 assertions)