Skip to content

[codex] Resolve upstream proxy hostnames#39

Merged
madeye merged 1 commit into
mainfrom
codex/resolve-upstream-proxy-hostnames
Jun 14, 2026
Merged

[codex] Resolve upstream proxy hostnames#39
madeye merged 1 commit into
mainfrom
codex/resolve-upstream-proxy-hostnames

Conversation

@madeye

@madeye madeye commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • accept documented upstream proxy host:port values by resolving hostnames during parsing
  • preserve direct SocketAddr parsing for IP literals
  • cover bare HTTP, http://, and socks5:// localhost inputs without assuming IPv4 vs IPv6 resolution order

Tests

  • cargo test upstream_proxy_parse
  • cargo test
  • cargo clippy --all-targets -- -D warnings
  • cargo fmt --all -- --check
  • git diff --check

@madeye madeye marked this pull request as ready for review June 14, 2026 03:27
@madeye madeye force-pushed the codex/resolve-upstream-proxy-hostnames branch from 8dd2349 to 6ce2655 Compare June 14, 2026 03:37
@madeye madeye merged commit 3ef3635 into main Jun 14, 2026
@madeye madeye deleted the codex/resolve-upstream-proxy-hostnames branch June 14, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant