Skip to content

[codex] Sanitize proxy request hostnames#40

Merged
madeye merged 1 commit into
mainfrom
codex/sanitize-proxy-hostnames
Jun 14, 2026
Merged

[codex] Sanitize proxy request hostnames#40
madeye merged 1 commit into
mainfrom
codex/sanitize-proxy-hostnames

Conversation

@madeye

@madeye madeye commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • route HTTP CONNECT and SOCKS5 request construction through shared hostname validation
  • fall back to the destination IP when an SNI/DNS hostname contains unsafe bytes or invalid label structure
  • add focused tests for safe hostname use and CRLF/control-hostname fallback

Validation

  • cargo test connect_request
  • cargo test proxy_hostname_validation
  • cargo test
  • cargo fmt --all -- --check
  • cargo clippy --all-targets -- -D warnings
  • git diff --check

@madeye madeye marked this pull request as ready for review June 14, 2026 03:27
@madeye madeye force-pushed the codex/sanitize-proxy-hostnames branch from c4a1ee9 to 3bb860d Compare June 14, 2026 03:38
@madeye madeye merged commit b0e5e65 into main Jun 14, 2026
6 checks passed
@madeye madeye deleted the codex/sanitize-proxy-hostnames branch June 14, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant