Skip to content

chore: fix some comments to improve readability #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuoguojida wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: fix some comments to improve readability #1092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@magic-sdk/provider/src/util/web-crypto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function clearKeys() {
}

export async function createJwt() {
// will return undefined is webcrypto is not supported
// will return undefined if webcrypto is not supported
const publicJwk = await getPublicKey();

if (!publicJwk) {
Expand Down Expand Up @@ -82,7 +82,7 @@ async function generateWCKP() {
const { subtle } = window.crypto;
const kp = await subtle.generateKey(
EC_GEN_PARAMS,
false, // need to export the public key, while keep private key non-extractable
false, // need to export the public key, while keeping private key non-extractable
['sign'],
);

Expand Down