Repository navigation
Conversation
Contributor
|
Merged, thanks. I confirmed the cause in magpie's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for welcoming GoAnyAPI into the Magpie community plugins and for the careful review of #472. I appreciate the work you put into getting the integration ready and merged.
This small follow-up fixes the GoAnyAPI icon in the Plugins → Discover card, refreshes its English and Chinese summaries, and adds its official website to the card's detail page.
iconURL from the GoAnyAPI entry inregistry.json. The Discover card currently passes that URL to the built-in icon renderer, which treats it as a local icon name and falls back to the generic cube. The plugin'spackage.jsonstill providesmagpie.icon; Magpie's package metadata path fetches and stores that image before displaying it.https://goanyapi.com/as the package'shomepage, which Magpie already displays as a Homepage link in plugin details. Bump the package to0.1.1because the communitydistbranch keeps each packed version immutable.Validation:
registry.jsonandpackages/goanyapi/package.jsonsuccessfully.After merge, the next
distbuild will make0.1.1available to Magpie. An npm first publish is not required for this update.