Skip to content

Align compliance_status enum with description#31

Merged
i7an merged 1 commit into
mainfrom
fix-compliance-status-enum
Apr 27, 2026
Merged

Align compliance_status enum with description#31
i7an merged 1 commit into
mainfrom
fix-compliance-status-enum

Conversation

@i7an
Copy link
Copy Markdown
Contributor

@i7an i7an commented Apr 24, 2026

Motivation

Actualize compliance_status enum.

Summary by CodeRabbit

Release Notes

  • Updates
    • Updated compliance status values for sending domains to reflect refined verification lifecycle stages, including new statuses for demo exhaustion, questionnaire requests, and card verification steps.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

📝 Walkthrough

Walkthrough

The SendingDomain.compliance_status enum in the OpenAPI specification has been updated. Four enum values (initial, pending, pending_cc, exhausted) were removed and three new values (demo_exhausted, awaiting_questionnaire, awaiting_card_verification) were added, with remaining statuses reordered.

Changes

Cohort / File(s) Summary
OpenAPI Schema Update
specs/email-sending.openapi.yml
Updated SendingDomain.compliance_status enum: removed initial, pending, pending_cc, exhausted; added demo_exhausted, awaiting_questionnaire, awaiting_card_verification; reordered remaining statuses.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • IgorDobryn
  • DagonWat
  • VladimirTaytor

Poem

🐰 A status update hops through the schema,
Old states fade like morning light,
New paths emerge: awaiting, exhausted, verified—
The compliance journey takes shape anew! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete, providing only minimal motivation without detailing changes, testing steps, or visual comparisons as required by the template. Expand the description to include: detailed list of enum values removed and added; testing instructions; before/after comparison table for the OpenAPI schema changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating the compliance_status enum to align with its documented description.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-compliance-status-enum

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@i7an i7an requested review from DagonWat and IgorDobryn April 24, 2026 09:51
@i7an i7an requested a review from piobeny April 24, 2026 11:10
@i7an i7an merged commit 51060e4 into main Apr 27, 2026
2 checks passed
@i7an i7an deleted the fix-compliance-status-enum branch April 27, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants