Skip to content

Revert "Remove accounts/{account_id} from all endpoints"#33

Merged
i7an merged 1 commit into
mainfrom
revert-29-remove-account-id
Apr 29, 2026
Merged

Revert "Remove accounts/{account_id} from all endpoints"#33
i7an merged 1 commit into
mainfrom
revert-29-remove-account-id

Conversation

@i7an
Copy link
Copy Markdown
Contributor

@i7an i7an commented Apr 29, 2026

Reverts #29

Summary by CodeRabbit

  • Breaking Changes
    • Multiple API endpoints have been restructured to be account-scoped across Account Management, Contacts, Email Sending, Sandbox, and Email Templates services. All affected operations now require an Account ID parameter in the request path.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Updated five OpenAPI specifications to introduce account-scoping across endpoints by adding account_id as a required path parameter. Routes were transformed from global paths (e.g., /api/contacts) to account-prefixed equivalents (e.g., /api/accounts/{account_id}/contacts). Added shared components.parameters.account_id definitions and updated corresponding cURL examples across account management, contacts, email sending, sandbox, and templates specifications.

Changes

Cohort / File(s) Summary
Account Management
specs/account-management.openapi.yml
Scoped account access, API token, and billing endpoints under /api/accounts/{account_id}/... pattern; added account_id parameter definition and updated 8+ endpoint paths with corresponding parameter references.
Contacts
specs/contacts.openapi.yml
Scoped contact, export, import, list, and field endpoints under account context; added account_id path parameter and updated all affected operations across nested resources.
Email Sending
specs/email-sending.openapi.yml
Rescoped sending domains, suppressions, stats, and email logs endpoints to be account-prefixed; added account_id parameter definition and wired it into 10+ related operations.
Sandbox
specs/sandbox.openapi.yml
Converted inbox, project, message, and attachment endpoints to /api/accounts/{account_id}/... scope; added account_id parameter definition with int64 type and applied to all affected path operations.
Templates
specs/templates.openapi.yml
Transformed email template endpoints from /api/email_templates... to /api/accounts/{account_id}/email_templates...; added account_id parameter definition and integrated into collection and resource operations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • PR #17 — Modifies the same OpenAPI specs (account-management, contacts, email-sending, sandbox, templates) with account-scoped paths and components.parameters.account_id definitions.
  • PR #29 — Directly related; modifies shared components.parameters.account_id across the same specs, representing inverse or complementary account-scoping changes.
  • PR #6 — Updates contacts and related specs to introduce account-scoped endpoints and parameter structures similar to this PR's approach.

Suggested reviewers

  • VladimirTaytor
  • mklocek
  • IgorDobryn
  • Ma-Anna

Poem

🐰 Account IDs now guide the way,
Through paths that structure, scope, and play,
From global routes to bounded domains,
The API spec now entertains!
With {account_id} in every door,
Our specs are scoped like never before. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is largely incomplete. It only mentions reverting PR #29 but lacks the required template sections including Motivation, detailed Changes, How to test, and visual examples. Expand the description to follow the repository template: add Motivation section explaining why the revert is needed, detail all Changes with bullet points, provide testing instructions with checkboxes, and include before/after images if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and specifically describes the main change: reverting a previous commit that removed account_id scoping from endpoints.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-29-remove-account-id

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@i7an i7an merged commit 23d52c3 into main Apr 29, 2026
1 of 2 checks passed
@i7an i7an deleted the revert-29-remove-account-id branch April 29, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants