Skip to content

[WEB-7945] fix(security): prevent shell injection in feature-deployment.yml #9334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 2 commits into from
Jul 1, 2026
+14 −4
Merged

[WEB-7945] fix(security): prevent shell injection in feature-deployment.yml #9334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e2c7fd
[WEB-7945] fix(security): prevent shell injection in feature-deployme…
mguptahub Jun 30, 2026
2548deb
[WEB-7945] fix: strip CR/LF from base_tag_name before writing to GITH…
mguptahub Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .github/workflows/feature-deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,31 @@ jobs:
steps:
- id: set_env_variables
name: Set Environment Variables
env:
# Bind user-controlled workflow inputs and branch refs to env vars so
# they are never string-interpolated into the shell script by GitHub
# Actions (prevents expression-injection / shell-injection).
INPUT_BASE_TAG_NAME: ${{ github.event.inputs.base_tag_name }}
GH_TARGET_BRANCH: ${{ env.TARGET_BRANCH }}
run: |
# Strip CR/LF from user-supplied input to prevent $GITHUB_OUTPUT
# injection: a newline in the value would forge extra output keys.
SAFE_BASE_TAG=$(printf '%s' "$INPUT_BASE_TAG_NAME" | tr -d '\r\n')

echo "BUILDX_DRIVER=docker-container" >> $GITHUB_OUTPUT
echo "BUILDX_VERSION=latest" >> $GITHUB_OUTPUT
echo "BUILDX_PLATFORMS=linux/amd64" >> $GITHUB_OUTPUT
echo "BUILDX_ENDPOINT=" >> $GITHUB_OUTPUT

if [ "${{ github.event.inputs.base_tag_name }}" != "" ]; then
echo "AIO_BASE_TAG=${{ github.event.inputs.base_tag_name }}" >> $GITHUB_OUTPUT
if [ "$SAFE_BASE_TAG" != "" ]; then
echo "AIO_BASE_TAG=$SAFE_BASE_TAG" >> $GITHUB_OUTPUT
else
echo "AIO_BASE_TAG=develop" >> $GITHUB_OUTPUT
fi

echo "TARGET_BRANCH=${{ env.TARGET_BRANCH }}" >> $GITHUB_OUTPUT
echo "TARGET_BRANCH=$GH_TARGET_BRANCH" >> $GITHUB_OUTPUT

FLAT_BRANCH_NAME=$(echo "${{ env.TARGET_BRANCH }}" | sed 's/[^a-zA-Z0-9]/-/g')
FLAT_BRANCH_NAME=$(echo "$GH_TARGET_BRANCH" | sed 's/[^a-zA-Z0-9]/-/g')
echo "FLAT_BRANCH_NAME=$FLAT_BRANCH_NAME" >> $GITHUB_OUTPUT

- id: checkout_files
Expand Down
Loading