fix: Use bevy_platform::time::Instant in the script pipeline#543
Merged
Conversation
std::time::Instant::now() panics at runtime on wasm32-unknown-unknown.
Open
|
Review changes with Changed Files
|
makspll
approved these changes
May 27, 2026
makspll
changed the title
CI is red on every job, but not from this change: the benchmark/diff jobs fail installing bencher because its current source uses Duration::from_hours, which is only const-stable on Rust >= 1.91, while rust-toolchain.toml pins 1.89.0. The build/test matrix also trips over the pinned toolchain (clippy component missing) and gets cancelled by fail-fast. Bump the pin to 1.91.0 and declare the clippy/rustfmt components so the toolchain is complete.
auto-merge was automatically disabled
May 27, 2026 19:59
Head branch was pushed to by a user without write access
Contributor
Author
|
Pushed a commit to fix CI. It was red across the board, but not because of this change. The benchmark and diff jobs fail while installing bencher, because bencher's current source uses I bumped |
Contributor
🔍 Binding Differences Detected
b/crates/bindings/bevy_asset_bms_bindings/src/lib.rsindex 776c17c..312c549 100644
--- a/crates/bindings/bevy_asset_bms_bindings/src/lib.rs
+++ b/crates/bindings/bevy_asset_bms_bindings/src/lib.rs
@@ -334,7 +334,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise negation (`!`) of the bits in a flags value, truncating the result.",
+ " The bitwise negation (`!`) of the bits in `self`, truncating the result.",
&["_self"],
)
.register_documented(
@@ -355,7 +355,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " Whether all set bits in a source flags value are also set in a target flags value.",
+ " Whether all set bits in `other` are also set in `self`.",
&["_self", "other"],
)
.register_documented(
@@ -376,7 +376,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The intersection of a source flags value with the complement of a target flags\n value (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `difference` won't truncate `other`, but the `!` operator will.",
+ " The intersection of `self` with the complement of `other` (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `difference` won't truncate `other`, but the `!` operator will.",
&["_self", "other"],
)
.register_documented(
@@ -466,7 +466,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise or (`|`) of the bits in two flags values.",
+ " The bitwise or (`|`) of the bits in `self` and `other`.",
&["_self", "other"],
)
.register_documented(
@@ -487,7 +487,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise and (`&`) of the bits in two flags values.",
+ " The bitwise and (`&`) of the bits in `self` and `other`.",
&["_self", "other"],
)
.register_documented(
@@ -508,7 +508,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " Whether any set bits in a source flags value are also set in a target flags value.",
+ " Whether any set bits in `other` are also set in `self`.",
&["_self", "other"],
)
.register_documented(
@@ -542,7 +542,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " Whether all bits in this flags value are unset.",
+ " Whether all bits in `self` are unset.",
&["_self"],
)
.register_documented(
@@ -563,7 +563,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The intersection of a source flags value with the complement of a target flags\n value (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `remove` won't truncate `other`, but the `!` operator will.",
+ " The intersection of `self` with the complement of `other` (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `remove` won't truncate `other`, but the `!` operator will.",
&["_self", "other"],
)
.register_documented(
@@ -606,7 +606,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The intersection of a source flags value with the complement of a target flags value (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `difference` won't truncate `other`, but the `!` operator will.",
+ " The intersection of `self` with the complement of `other` (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `difference` won't truncate `other`, but the `!` operator will.",
&["_self", "other"],
)
.register_documented(
@@ -627,7 +627,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise exclusive-or (`^`) of the bits in two flags values.",
+ " The bitwise exclusive-or (`^`) of the bits in `self` and `other`.",
&["_self", "other"],
)
.register_documented(
@@ -648,7 +648,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise exclusive-or (`^`) of the bits in two flags values.",
+ " The bitwise exclusive-or (`^`) of the bits in `self` and `other`.",
&["_self", "other"],
)
.register_documented(
@@ -669,7 +669,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise or (`|`) of the bits in two flags values.",
+ " The bitwise or (`|`) of the bits in `self` and `other`.",
&["_self", "other"],
);
let registry = world.get_resource_or_init::();
|
Contributor
|
Bencher Report| Branch | wasm-platform-instant |
| Testbed | linux-gha |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🚨 5 Alerts
🐰 View full continuous benchmarking report in BencherRust 1.91 renders the elided lifetime in std::any::type_name output, so ScriptFunction<fn(..)> is now ScriptFunction<'_, fn(..)>. Update the hardcoded expected function name in test_invalid_amount_of_args_errors_nicely to match. Companion to the 1.91 toolchain bump.
auto-merge was automatically disabled
May 27, 2026 20:56
Head branch was pushed to by a user without write access
Contributor
Author
|
One more commit. With the toolchain on 1.91, the only remaining failure was |
Contributor
Author
|
@makspll I confirmed this last one actually runs locally - sorry for all the back and forth. This should unblock other open PRs as well since the pipeline has been broke |
Owner
|
All good! Thanks for the contribution :D |
Contributor
🔍 Binding Differences Detected
b/crates/bindings/bevy_asset_bms_bindings/src/lib.rsindex 776c17c..312c549 100644
--- a/crates/bindings/bevy_asset_bms_bindings/src/lib.rs
+++ b/crates/bindings/bevy_asset_bms_bindings/src/lib.rs
@@ -334,7 +334,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise negation (`!`) of the bits in a flags value, truncating the result.",
+ " The bitwise negation (`!`) of the bits in `self`, truncating the result.",
&["_self"],
)
.register_documented(
@@ -355,7 +355,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " Whether all set bits in a source flags value are also set in a target flags value.",
+ " Whether all set bits in `other` are also set in `self`.",
&["_self", "other"],
)
.register_documented(
@@ -376,7 +376,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The intersection of a source flags value with the complement of a target flags\n value (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `difference` won't truncate `other`, but the `!` operator will.",
+ " The intersection of `self` with the complement of `other` (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `difference` won't truncate `other`, but the `!` operator will.",
&["_self", "other"],
)
.register_documented(
@@ -466,7 +466,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise or (`|`) of the bits in two flags values.",
+ " The bitwise or (`|`) of the bits in `self` and `other`.",
&["_self", "other"],
)
.register_documented(
@@ -487,7 +487,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise and (`&`) of the bits in two flags values.",
+ " The bitwise and (`&`) of the bits in `self` and `other`.",
&["_self", "other"],
)
.register_documented(
@@ -508,7 +508,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " Whether any set bits in a source flags value are also set in a target flags value.",
+ " Whether any set bits in `other` are also set in `self`.",
&["_self", "other"],
)
.register_documented(
@@ -542,7 +542,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " Whether all bits in this flags value are unset.",
+ " Whether all bits in `self` are unset.",
&["_self"],
)
.register_documented(
@@ -563,7 +563,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The intersection of a source flags value with the complement of a target flags\n value (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `remove` won't truncate `other`, but the `!` operator will.",
+ " The intersection of `self` with the complement of `other` (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `remove` won't truncate `other`, but the `!` operator will.",
&["_self", "other"],
)
.register_documented(
@@ -606,7 +606,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The intersection of a source flags value with the complement of a target flags value (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `difference` won't truncate `other`, but the `!` operator will.",
+ " The intersection of `self` with the complement of `other` (`&!`).\n This method is not equivalent to `self & !other` when `other` has unknown bits set.\n `difference` won't truncate `other`, but the `!` operator will.",
&["_self", "other"],
)
.register_documented(
@@ -627,7 +627,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise exclusive-or (`^`) of the bits in two flags values.",
+ " The bitwise exclusive-or (`^`) of the bits in `self` and `other`.",
&["_self", "other"],
)
.register_documented(
@@ -648,7 +648,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise exclusive-or (`^`) of the bits in two flags values.",
+ " The bitwise exclusive-or (`^`) of the bits in `self` and `other`.",
&["_self", "other"],
)
.register_documented(
@@ -669,7 +669,7 @@ pub(crate) fn register_render_asset_usages_functions(world: &mut World) {
};
output
},
- " The bitwise or (`|`) of the bits in two flags values.",
+ " The bitwise or (`|`) of the bits in `self` and `other`.",
&["_self", "other"],
);
let registry = world.get_resource_or_init::();
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipeline/machines.rsusesstd::time::Instant, which doesn't work on wasm:std::time::Instant::now()panics at runtime onwasm32-unknown-unknown("time not implemented on this platform"); the machine tick loop calls it every frame.bevy_platform::time::Instantis already a dependency here — it'sstd::time::Instanton native andweb_timeon wasm. Same API, no behavior change off wasm, no new dep.Towards #166.