smartcontract: rename subscribe to use roles terminology#3499
Merged
martinsander00 merged 4 commits intomainfrom Apr 15, 2026
Merged
smartcontract: rename subscribe to use roles terminology#3499martinsander00 merged 4 commits intomainfrom
martinsander00 merged 4 commits intomainfrom
Conversation
martinsander00
force-pushed
the
ms/subscribe-rename
branch
from
123f4d8 to
d8bab0d
Compare
Rename subscribe_user_to_multicastgroup → update_user_multicastgroup_subscription and process_subscribe_multicastgroup → process_update_multicastgroup_subscription to reflect that these functions handle both subscribe and unsubscribe. Simplify the status guard to use a positive is_subscribe check instead of double-negated !is_unsubscribe_only. Resolves #3498
martinsander00
force-pushed
the
ms/subscribe-rename
branch
from
d8bab0d to
ab04a62
Compare
…Roles Rename instruction variant, args struct, SDK command, and trait method to use 'roles' terminology, clarifying the instruction manages both publisher and subscriber roles rather than just subscriptions.
martinsander00
changed the title
elitegreg
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubscribeMulticastGroupinstruction variant toUpdateMulticastGroupRoles— the instruction manages both publisher and subscriber roles, so "subscribe" was misleadingprocess_subscribe_multicastgroup→process_update_multicastgroup_roles), args struct (MulticastGroupSubscribeArgs→UpdateMulticastGroupRolesArgs), and SDK command/trait method to matchis_unsubscribe_onlywithhas_role(inverted logic, same semantics), preserving the existing behavior that allows role removal for any user status and role addition for Pending/Activated/Updating usersLines of Code
All changes are pure renames — no behavioral, wire-format, or user-facing CLI changes.
Testing Verification