fix: log errors instead of silently swallowing prompt failures#44
Open
andrewwhitecdw wants to merge 6 commits into
Open
fix: log errors instead of silently swallowing prompt failures#44andrewwhitecdw wants to merge 6 commits into
andrewwhitecdw wants to merge 6 commits into
Conversation
Adds 4 custom checks based on AGENTS.md conventions: - TypeScript type check - Code style review - Commit message format - Architecture review
Remove filler documentation that described non-existent columns (Messages, First, Last, Agents) and inline single-use header/separator variables. Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev> Co-authored-by: andrew-white-1 <andrewh@cdw.com>
Add Continue AI checks for PR review
Two try/catch blocks around session.prompt calls silently discarded errors. Log them to console.error so operators can diagnose why messages are not being delivered after idle/compaction events. Signed-off-by: Andrew White <andrewh@cdw.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Two
try/catchblocks aroundsession.prompt()calls silently discarded errors, making it impossible to diagnose why messages were not delivered after idle/compaction events.Fix
Log caught errors to
console.errorwith context about which session and event type failed.Verification
git diffshows only the two catch blocks now callconsole.error. No functional behavior changes.