Implement .netrc support#25
Open
truelecter wants to merge 5 commits into
Open
Conversation
NotAShelf
reviewed
Jun 12, 2026
NotAShelf
left a comment
NotAShelf
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR and the AI disclosure. I've left one quick comment. Other than this please:
- Reword your commits to patch the repository conventions (scoped commits)
- Add a quick section under documentation about the usage.
Load credentials from ~/.netrc, or from the path in NETRC when set. For upstreams without username in config, match credentialsby hostname and fall back to an optional default entry.
Author
|
Restructured commit messages, added .netrc note under Upstream Authentication README section. I did not include an example of the netrc file, but I'll add it if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note, despite all my tries, I suck at rust and rust code was written with Claude 4.8 assistance. I cleaned excessive comments, simplified some functions it overengineered a bit and to my eye code looks reasonable.
I tested it myself and currently using this fork on my configuration.
Implements #23