Skip to content

fix(ci): gracefully fall back to GITHUB_TOKEN when App secrets absent#28

Merged
maniramezan merged 1 commit into
mainfrom
fix/release-please-app-token-fallback
Jun 6, 2026
Merged

fix(ci): gracefully fall back to GITHUB_TOKEN when App secrets absent#28
maniramezan merged 1 commit into
mainfrom
fix/release-please-app-token-fallback

Conversation

@maniramezan
Copy link
Copy Markdown
Owner

Two issues when RELEASE_PLEASE_APP_ID/RELEASE_PLEASE_APP_PRIVATE_KEY are not configured:

  1. create-github-app-token fails hard, skipping the release step. Add continue-on-error: true and fall back to secrets.GITHUB_TOKEN so release-please always runs.

  2. fromJson(steps.release.outputs.pr).number in env: is evaluated before the if: guard, crashing with "Error reading JToken" when the release step was skipped (empty output). Move the extraction into the run: shell via jq, and tighten the if: to also require steps.app-token.outcome == 'success' so auto-merge only fires when the App token is actually available.

Summary

  • Describe the change and why it is needed.

Two issues when RELEASE_PLEASE_APP_ID/RELEASE_PLEASE_APP_PRIVATE_KEY
are not configured:

1. create-github-app-token fails hard, skipping the release step. Add
   continue-on-error: true and fall back to secrets.GITHUB_TOKEN so
   release-please always runs.

2. fromJson(steps.release.outputs.pr).number in env: is evaluated
   before the if: guard, crashing with "Error reading JToken" when the
   release step was skipped (empty output). Move the extraction into
   the run: shell via jq, and tighten the if: to also require
   steps.app-token.outcome == 'success' so auto-merge only fires when
   the App token is actually available.
@maniramezan maniramezan merged commit c7996ab into main Jun 6, 2026
2 checks passed
@maniramezan maniramezan deleted the fix/release-please-app-token-fallback branch June 6, 2026 17:26
This was referenced Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant