feat(components): add SegmentDensity (Regular/Compact) to SegmentedContent#30
Merged
Conversation
…ntent Compact reduces the segment title's vertical padding (half) and the height floor to ~32dp (spacing.x4) instead of the 48dp minimum touch target, matching a native compact segmented control. Default Regular preserves current sizing. Threaded through both public overloads, SegmentBar, the even/intrinsic/scrollable rows, and SegmentSlot. The tap target shrinks with the control in compact, documented on the enum. Mirrors SegmentDensity added to SwiftUIComponents' SegmentedPicker.
Add a SegmentedContentCompactPreview (+ Showkase entry) and a Density control (Regular/Compact) on the sample app's SegmentedContent page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a density preset to
SegmentedContent, mirroringSegmentDensityadded to SwiftUIComponents'SegmentedPicker(iOS/Android parity).What
spacing.x4) and the title's vertical padding halves, matching a native compact segmented control.Threaded through both public overloads →
SegmentBar→ even/intrinsic/scrollable rows →SegmentSlot. New param defaults toRegular, so existing callers are unaffected (source-compatible).Showcase & sample
SegmentedContentCompactPreview(@PreviewLightDark) + matching Showkase entry.Tradeoff (documented on the enum)
At
Compactthe tap target shrinks with the control (below the 48dp guideline) — use where a tighter control matters more than a generous tap area.Verification
:componentsand:samplecompile, ktlint, detekt all pass;:catalog:assembleDebugsucceeds;:components:testDebugUnitTestpasses.Follow-up (after release)
Bump the Android app's
composeUiLiband setdensity = SegmentDensity.Compacton the video-detailssegviewheader (parity with the iOS change already on main).