fix(ci): bump-minor-pre-major so breaking changes stay in 0.x#31
Merged
Conversation
Without this flag Release Please treats a BREAKING CHANGE footer as a major bump even while the version is still 0.x, producing 1.0.0 instead of 0.6.0. Setting bump-minor-pre-major: true keeps breaking changes in the minor segment until we explicitly decide to ship v1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release Please opened PR #29 proposing
1.0.0because commit #26 (renameSelectionSheet → SelectionList) included aBREAKING CHANGE:footer. By default, Release Please follows semver strictly and treats any breaking change as a major bump — even in0.x.Fix
Add
bump-minor-pre-major: truetorelease-please-config.json. This tells Release Please to treat breaking changes as minor bumps while the major version is still0, so the next release will be0.6.0instead of1.0.0.After merging
Close PR #29 (
chore(main): release 1.0.0) and re-run (or let CI trigger) the Release Please workflow. It will re-calculate and open a new PR proposing0.6.0.