Repository navigation
Rebuild the website when a release is published - #11
Merged
Merged
Conversation
…s name the new files
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The website's download buttons read the latest release when the site is built. Vercel only builds on pushes to
main, so after v0.1.0 was published the live site still had the build from before it, and every button went to the Releases page.The Site workflow now also runs when a release is published and calls Vercel's deploy hook (
VERCEL_DEPLOY_HOOKsecret), so the site is rebuilt with the new release's files. Without the secret it warns and does nothing. The comment inrelease.tssaid this already happened; now it does.How I checked it
pnpm buildinsite/with v0.1.0 published: the buttons and install steps link toreleases/download/v0.1.0/…for the DMG, the setup.exe, the.deb, the.rpmand the AppImage.Left out
Creating the deploy hook in Vercel and storing it as the
VERCEL_DEPLOY_HOOKsecret is done by hand.