Repository navigation
Accept a static-pie localhostd in the release workflow - #9
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The v0.1.0 Release run failed at "Build localhostd for WSL", so the Windows installer was skipped. The binary was fine: the runner's newer
filedescribes it asstatic-pie linked, and the check only acceptedstatically linked. Both now pass; a dynamically linked binary still fails.How I checked it
localhostd --versionandlocalhostd --stdio < /dev/nulllocally (the next two steps of the check, which never ran): both exit 0.Left out
Re-running the release: the
v0.1.0tag moves to the merge commit once this is in.