Replace unicode emoji characters, allowing them to be customized by renderer rules#53
Open
carter-thaxton wants to merge 3 commits into
Open
Replace unicode emoji characters, allowing them to be customized by renderer rules#53carter-thaxton wants to merge 3 commits into
carter-thaxton wants to merge 3 commits into
Conversation
… by renderer rules
Use enforced code style for spaces. The code coverage checker was complaining about the 'unnecessary' check that I added in the previous commit, in case the replacement regexp didn't match anything.
Specifically, add a test that emojies using unicode characters are also wrapped by such renderer rules, covering the new behavior in this pull request.
Author
|
I added some tests to cover this new behavior, and fixed the linter errors in my previous commit. |
|
Any chance this proposal can go further? It would be interesting for accessibility purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very straightforward implementation of #43. "It just works!"
I'm sure it's possible to provide an option to control this behavior, but it doesn't seem necessary.