Add Trustabl security scanning to CI - #1
Open
joshua-trustabl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across your repo and I like how it creatively combines Gemini's Google Search grounding with CrewAI to deliver humorous, context-aware GitHub roasts, especially the streaming FastAPI design that gives real-time feedback during the roast generation process. I scanned the repo, and noticed some agent runtime reliability findings that might be worth reviewing.
Add LlmAgent description
In src/github_roaster/crew.py, the LlmAgent class inherits from crewAI's Agent but does not define a descriptive
descriptionfield in its constructor. This impacts runtime behavior by preventing clear logging, debugging, or monitoring of agent-specific task routing and decision logic.Configure agent safety_settings
In src/github_roaster/crew.py, the Gemini LLM configuration lacks explicit
safety_settingson the LlmAgent instantiation. This matters because without tailored safety configurations, the agent may produce inappropriate or inconsistent outputs during roasts, especially when querying diverse GitHub profiles.Define agent tools in agent configuration
In src/github_roaster/config/agents.yaml, agents are defined without explicit
toolsfields, even though the LlmAgent class is coded to supportgoogle_search. This means tool binding is implicit rather than declarative, reducing reliability and making it harder to audit or override tools per agent at runtime.Recommendations are based on our understanding of agent runtime reliability, some findings may be intentional. Please let us know if this was intentional or if our findings are helpful so we can improve the accuracy of the scanner.
Best,
Trustabl.ai
Open-source AI agent reliability scanner (runs locally, GitHub Action)