fix(editor): stabilize visual table line breaks - #634
Merged
Conversation
Route Enter events from Safari's shared contenteditable table through the same controlled cell path, and suppress duplicate native line-break input.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
or move the caret back
Why
Safari targets keyboard events at the shared contenteditable table, while Chromium can target the focused cell. The original #632 implementation listened for Enter only on each cell, so Safari fell through to native editing behavior: middle breaks became spaces, boundary breaks could appear briefly, and subsequent input jumped back to the original line.
Validation
NextAlpha, Al
Nextpha, and Alpha
Next for start, middle, and end insertion respectively
An initial concurrent full-suite run had one unrelated block-drag test failure; the isolated test and the subsequent serial full suite both passed.
Risk
Refs #632