fix(editor): preserve authored blank line height - #637
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
An empty row at the end of the document was reclassified after text was entered below it. The editor then hid the real row and replaced it with an 8px layout widget, which made content move upward and destabilized caret, IME, focus, reopen, and mode-switch behavior.
Validation
pnpm --filter @markra/editor test— 413 tests passedpnpm --filter @markra/editor build— passedpnpm --filter @markra/editor typecheck:test— passedpnpm --filter @markra/app test— 1484 tests passedpnpm --filter @markra/app build— passedpnpm --filter @markra/app typecheck:test— passedRisk