perf(editor): reduce live preview typing latency - #638
Merged
Conversation
Keep expensive visual block previews mounted when edits do not touch them. Coalesce draft persistence and defer document summaries off the input path. Closes #636
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #636 reports severe typing lag in Markdown documents. Profiling also reproduced the problem in small documents when expensive preview blocks were located after the caret. The input path was rebuilding preview state and, on desktop, queueing a settings-store read/write/save for every character.
Validation
pnpm --filter @markra/editor exec vitest run --environment jsdom --globals --maxWorkers=1 --no-file-parallelism— 35 files, 430 tests passed after the compatibility adjustmentpnpm --filter @markra/app exec vitest run --environment jsdom --globals --maxWorkers=1 --no-file-parallelism— 130 files, 1486 tests passedpnpm --filter @markra/editor build && pnpm --filter @markra/editor typecheck:test— passed after the compatibility adjustmentpnpm --filter @markra/app build && pnpm --filter @markra/app typecheck:test— passedRisk
Closes #636